Solve Bug in Sitefinity having multiple sf-media-field in same designer view (document/videos) always change/update first sf-media-field control. Also bug present when having sf-auto-open-selector attribute present in sf-media-field always open first sf-media-field#2716
Open
Abhijeet2019 wants to merge 3 commits intoSitefinity:masterfrom
Open
Solve Bug in Sitefinity having multiple sf-media-field in same designer view (document/videos) always change/update first sf-media-field control. Also bug present when having sf-auto-open-selector attribute present in sf-media-field always open first sf-media-field#2716Abhijeet2019 wants to merge 3 commits intoSitefinity:masterfrom
Abhijeet2019 wants to merge 3 commits intoSitefinity:masterfrom
Conversation
Bug in Sitefinity having multiple sf-media-selector in same designer view (document/videos) always update first sf-media-selector element. Also bug present when having autoOpenSelector attribute presents always open first sf-media-selector.
|
Hello @Abhijeet2019. Thank you for submitting this item, reporting this bug and a fix. I wanted to let you know that this repository is intended to be used for reference for our customers, and this PR will not be merged here, we will fix this issue internally and we will ship it with a patch. In all likelihood this fix will be shipped with the first patch for Sitefinity 14.3. Best regards, |
Author
|
Thanks @stefankoserkov. I am getting this issue since from version 11.x and I have above workaround takes place in our code but when I upgrade to 14.2 issue still persist and I thought of sharing this workaround so in future version/patch it will be available. Regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug in Sitefinity having multiple sf-media-field in same designer view (document/videos) always update first sf-media-field element. Also bug present when having sf-auto-open-selector attribute presents always open first sf-media-field.
code lines added
//Add below lines of code to solve multiple sf-media-field selector in same designer view
if (mediaElement && mediaElement.length > 0) {
var el = mediaElement[0].querySelector('.mediaSelectorModal');
if (el) {
var ngEl = angular.element(el);
if (ngEl) {
mediaSelector = ngEl;
}
}
}