Skip to content

Allow undefined fields on JsonObject #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skiplabsdaniel wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow undefined fields on JsonObject #1109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion skiplang/skjson/ts/binding/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ export type Json =
/**
* Objects containing `Json` values.
*/
export type JsonObject = { readonly [key: string]: Json | null };
export type JsonObject = { readonly [key: string]: Json | null | undefined };

export type Exportable =
| null
Expand Down
1 change: 1 addition & 0 deletions skipruntime-ts/helpers/src/external.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ export function defaultParamEncoder(params: Json): string {
if (typeof params == "object") {
const queryParams: { [param: string]: string } = {};
for (const [key, value] of Object.entries(params)) {
if (value === undefined) continue;
if (typeof value == "object") queryParams[key] = JSON.stringify(value);
else queryParams[key] = value.toString();
}
Expand Down