[Scrabble task] Solution for scrabble puzzle #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Jan 20, 2017
Training/Medium/scrabble.rb
Outdated
| letters_weight[2] = %w(d g) | ||
| letters_weight[3] = %w(b c m p) | ||
| letters_weight[4] = %w(f h v w y) | ||
| letters_weight[5] = ['k'] |
Training/Medium/scrabble.rb
Outdated
|
|
||
| def initialize | ||
| @n = gets.to_i | ||
| @dictionary = @n.times.each_with_object([]) { |_, result| result << gets.chomp } |
There was a problem hiding this comment.
Define a local n variable here. You don't need instance one.
@dictionary = Array.new(n) { gets.chomp }
Training/Medium/scrabble.rb
Outdated
| end | ||
|
|
||
| def init_letters_weight | ||
| letters_weight = {} |
There was a problem hiding this comment.
You can define a hash to return at once:
def init_letters_weight
{
1 => %w(e a i o n r t l s u),
2 => %w(d g),
...
}
end| end | ||
|
|
||
| def matching?(word) | ||
| word.each_char do |char| |
There was a problem hiding this comment.
One way to refactor is to use an any? block for this method.
Training/Medium/scrabble.rb
Outdated
| end | ||
|
|
||
| obj = Scrabble.new | ||
| obj.start |
Slavunderkind
force-pushed
the
scrabble_solution
branch
from
bddf776 to
638fceb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.