Resolve typechecking errors with strict Luau in Trove.#263
Open
MaximumADHD wants to merge 8 commits intoSleitnick:mainfrom
Open
Resolve typechecking errors with strict Luau in Trove.#263MaximumADHD wants to merge 8 commits intoSleitnick:mainfrom
MaximumADHD wants to merge 8 commits intoSleitnick:mainfrom
Conversation
|
Bless! |
Owner
|
Nice, good timing with #261. I'll check this out over the weekend |
Repository owner
deleted a comment from
ionungur365-sketch
Feb 6, 2026
Repository owner
deleted a comment from
ionungur365-sketch
Feb 6, 2026
Repository owner
deleted a comment from
ionungur365-sketch
Feb 6, 2026
Repository owner
deleted a comment from
ionungur365-sketch
Feb 6, 2026
Repository owner
deleted a comment from
ionungur365-sketch
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This commit extends on #200. The recent changes to support
--!strictin Trove were good in principle, but had several problems because of Luau being Luau. This pull request attempts to resolve a lot of these problems.Unlike before, this allows the actual metatable-backed Trove type to be exported!
What was changed?
I've removed the manually-defined
Trovetype in favor of renaming theTroveInternaltype toTrove. Function signatures are now derived as they are written in theTrovetable. I also updated many of the types inTrackableto be generic-backed (defaults set toanyand...anywhen possible), which allows forTto be slotted in as the value ofself. It just works™!Hard to say is this is 100% bug-free, but I've been thoroughly checking against my
--!strictcodebase and the results are extremely promising!