Possible fix for issue #91 - TryDeconstructComponent now waits for components to Start#92
Open
eAi wants to merge 6 commits intoSleitnick:mainfrom
Open
Possible fix for issue #91 - TryDeconstructComponent now waits for components to Start#92eAi wants to merge 6 commits intoSleitnick:mainfrom
eAi wants to merge 6 commits intoSleitnick:mainfrom
Conversation
…mponents to Start and then Stops them rather than just avoiding stopping them entirely. This fixes a situation where the components are never stopped, so Stop isn't called and the Heartbeat (etc) functions are never unregistered.
…he component to never be stopped. This could be triggered by adding an instance to a valid place in the hierarchy then removing it in a single frame.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a possible fix for #91. TryDeconstructComponent now uses a Promise to wait for a component to Start if it hasn't already then Stops it rather than just avoiding stopping them entirely. This fixes a situation where the components are never stopped, so Stop isn't called and the Heartbeat (etc) functions are never unregistered.