Bugfix for PropertyExpander (issue #767) #768
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onetr1ck
changed the title
onetr1ck
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The property expander malforms SOAP-Requests if there are ${ present in it which are not part of a Property name. Property names must always start with ${ and end with } and have not any linebreaks in it. Thus i have added a very simple regex check to verify this before processing the content for expansion. This fixes issue #767.
Here is a simple explanation for the regex:
(?<=${) is a positive lookbehind assertion that matches the literal characters ${ at the beginning of the substring. This ensures that the match occurs after ${.
[^\r\n]+ matches any non-linebreak character 1..n times
it can be limited to a number of characters by replacing + with {1,256} e.g. from 1 to 256 times. This enforces the maximum length of 256 characters for the substring.
(?=}) is a positive lookahead assertion that matches the literal character } at the end of the substring. This ensures that the match occurs before }.