Skip to content

Implement relative date formatter for hourly choice sets #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FrankElias77 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Implement relative date formatter for hourly choice sets #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions SmartDeviceLinkService.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,12 +254,14 @@ - (void)presentForecastInteractionWithList:(NSArray *)forecasts ofType:(MWInfoTy
dateFormatShow.timeZone = [NSTimeZone timeZoneForSecondsFromGMT:0];
dateFormatShow.locale = self.localization.locale;

NSRelativeDateTimeFormatter *hourlyDateFormatShow = [[NSRelativeDateTimeFormatter alloc] init];
[hourlyDateFormatShow setUnitsStyle:NSRelativeDateTimeFormatterUnitsStyleShort];
Comment on lines +257 to +258
Copy link
Contributor

@joeljfischer joeljfischer Jul 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get rid of the warnings by moving this to iOS 13.0+


NSDateFormatter *dateFormatSpeak = [[NSDateFormatter alloc] init];
dateFormatSpeak.timeZone = [NSTimeZone timeZoneForSecondsFromGMT:0];
dateFormatSpeak.locale = self.localization.locale;

if (isHourlyForecast) {
dateFormatShow.dateFormat = self.localization[@"forecast.hourly.choice.show"];
dateFormatSpeak.dateFormat = self.localization[@"forecast.hourly.choice.speak"];
} else {
dateFormatShow.dateFormat = self.localization[@"forecast.daily.choice.show"];
Expand All @@ -282,7 +284,9 @@ - (void)presentForecastInteractionWithList:(NSArray *)forecasts ofType:(MWInfoTy
}

NSString *precipitationChanceString = [NSString stringWithFormat:@"Precipitation chance: %@", [forecast.precipitationChance stringValueForUnit:UnitPercentageDefault shortened:YES localization:self.localization]];
SDLChoiceCell *cell = [[SDLChoiceCell alloc] initWithText:[dateFormatShow stringFromDate:forecast.date] secondaryText:precipitationChanceString tertiaryText:nil voiceCommands:[vrCommands copy] artwork:[SDLArtwork artworkWithImage:[[[ImageProcessor sharedProcessor] imageFromConditionImage:forecast.conditionIcon] imageWithRenderingMode:UIImageRenderingModeAlwaysTemplate] asImageFormat:SDLArtworkImageFormatPNG] secondaryArtwork:nil];
NSString *dateString = isHourlyForecast ? [hourlyDateFormatShow localizedStringForDate:forecast.date relativeToDate:[[NSDate alloc] init]] : [dateFormatShow stringFromDate:forecast.date];

SDLChoiceCell *cell = [[SDLChoiceCell alloc] initWithText:dateString secondaryText:precipitationChanceString tertiaryText:nil voiceCommands:[vrCommands copy] artwork:[SDLArtwork artworkWithImage:[[[ImageProcessor sharedProcessor] imageFromConditionImage:forecast.conditionIcon] imageWithRenderingMode:UIImageRenderingModeAlwaysTemplate] asImageFormat:SDLArtworkImageFormatPNG] secondaryArtwork:nil];
[choices addObject:cell];
}

Expand Down Expand Up @@ -449,8 +453,8 @@ - (void)showForecastAtIndex:(NSUInteger)index fromList:(NSArray<Forecast *> *)fo
self.manager.screenManager.textField2Type = SDLMetadataTypeMinimumTemperature;

self.manager.screenManager.textField3 = [forecast.lowTemperature stringValueForUnit:temperatureType shortened:YES localization:self.localization];
self.manager.screenManager.textField3Type = SDLMetadataTypeMaximumTemperature
;
self.manager.screenManager.textField3Type = SDLMetadataTypeMaximumTemperature;

self.manager.screenManager.textField4 = [forecast.precipitationChance stringValueForUnit:percentageType shortened:YES localization:self.localization];
}

Expand Down