Skip to content

[Aqara/Dimmer Controller T1] Remove unused code(follow-up PR) #2662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
haedo-doo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Aqara/Dimmer Controller T1] Remove unused code(follow-up PR) #2662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions drivers/SmartThings/zigbee-switch/src/aqara-light/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,18 +54,9 @@ local function set_level_handler(driver, device, cmd)
device:send(Level.commands.MoveToLevelWithOnOff(device, level, dimming_rate))
end

local function init(self, device)
local value = { minimum = 2700, maximum = 6000 }
if device:get_model() == "lumi.light.cwacn1" then
value.maximum = 6500
end
emit_event_if_latest_state_missing(device, "main", capabilities.colorTemperature, capabilities.colorTemperature.colorTemperatureRange.NAME, capabilities.colorTemperature.colorTemperatureRange(value))
end

local aqara_light_handler = {
NAME = "Aqara Light Handler",
lifecycle_handlers = {
init = init,
added = device_added,
doConfigure = do_configure
},
Expand Down
3 changes: 1 addition & 2 deletions drivers/SmartThings/zigbee-switch/src/test/test_aqara_led_bulb.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ zigbee_test_utils.prepare_zigbee_env_info()

local function test_init()
test.mock_device.add_test_device(mock_device)
test.socket.capability:__expect_send(mock_device:generate_test_message("main", capabilities.colorTemperature.colorTemperatureRange({ minimum = 2700, maximum = 6000 })))
end

test.set_test_init_function(test_init)
Expand All @@ -52,7 +51,7 @@ test.register_coroutine_test(
test.socket.zigbee:__expect_send({
mock_device.id, cluster_base.write_manufacturer_specific_attribute(mock_device, PRIVATE_CLUSTER_ID,
PRIVATE_ATTRIBUTE_ID, MFG_CODE, data_types.Uint8, 1) })
-- test.socket.capability:__expect_send(mock_device:generate_test_message("main", capabilities.colorTemperature.colorTemperatureRange({ minimum = 2700, maximum = 6000 })))
test.socket.capability:__expect_send(mock_device:generate_test_message("main", capabilities.colorTemperature.colorTemperatureRange({ minimum = 2700, maximum = 6000 })))
end
)

Expand Down
3 changes: 1 addition & 2 deletions drivers/SmartThings/zigbee-switch/src/test/test_aqara_light.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ zigbee_test_utils.prepare_zigbee_env_info()

local function test_init()
test.mock_device.add_test_device(mock_device)
test.socket.capability:__expect_send(mock_device:generate_test_message("main", capabilities.colorTemperature.colorTemperatureRange({ minimum = 2700, maximum = 6000 })))
end

test.set_test_init_function(test_init)
Expand All @@ -54,7 +53,7 @@ test.register_coroutine_test(
test.socket.zigbee:__expect_send({
mock_device.id, cluster_base.write_manufacturer_specific_attribute(mock_device, PRIVATE_CLUSTER_ID,
PRIVATE_ATTRIBUTE_ID, MFG_CODE, data_types.Uint8, 1) })
-- test.socket.capability:__expect_send(mock_device:generate_test_message("main", capabilities.colorTemperature.colorTemperatureRange({ minimum = 2700, maximum = 6000 })))
test.socket.capability:__expect_send(mock_device:generate_test_message("main", capabilities.colorTemperature.colorTemperatureRange({ minimum = 2700, maximum = 6000 })))
end
)

Expand Down
Loading