Added PHI-HRT Stokes plotting to the PHI plotting example#12
Open
JonasSinjan wants to merge 2 commits intoSolarOrbiterWorkshop:mainfrom
Open
Added PHI-HRT Stokes plotting to the PHI plotting example#12JonasSinjan wants to merge 2 commits intoSolarOrbiterWorkshop:mainfrom
JonasSinjan wants to merge 2 commits intoSolarOrbiterWorkshop:mainfrom
Conversation
Contributor
JonasSinjan
commented
Sep 26, 2025
JonasSinjan
commented
- Added the HRT field stop fits file in examples/data to mask out the edges during the cases where we have the full FoV HRT stokes data
- Added loading function for the field stop
- Added plotting function to plot both the old and new HRT stokes format for a given wavelength position
Contributor
Author
|
Ah the build failed due to timeout. I suspect this is because the hrt-stokes files are quite large (400MB each) that need to be downloaded. Not sure how to get around this. |
samaloney
reviewed
Nov 26, 2025
|
|
||
| fig, (ax1, ax2) = plt.subplots(2,2, figsize = (15,12)) | ||
|
|
||
| assert stokes.ndim == 4 |
There was a problem hiding this comment.
Edge case but asserts aren't always raised python -O
| the field stop of the HRT telescope. | ||
| """ | ||
| if path is None: | ||
| path = "./data/HRT_field_stop.fits" |
There was a problem hiding this comment.
Is this file up/downloaded as part of this- if not maybe just require the path?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.