Fix incorrect bitwise operation in pixel color calculation#245
Open
antoncuranz wants to merge 1 commit intoSolderedElectronics:masterfrom
Open
Fix incorrect bitwise operation in pixel color calculation#245antoncuranz wants to merge 1 commit intoSolderedElectronics:masterfrom
antoncuranz wants to merge 1 commit intoSolderedElectronics:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
I have found that in ImageBMP.cpp, there is a problem with the extraction of colors from the palette array:
For files with 4bit and 8bit color depth, the palette array seems to store two 3bit colors per entry. Depending on the last bit of the color index, a different color should be extracted from it using a shift and an AND operation.
However, the shift operation seems to be done before the AND. Because of this, the lower 3bit color is always returned.
I fixed this by adding an extra pair of parentheses.