Conversation
.github/workflows/workflow.yml
Outdated
| - name: Install dependencies | ||
| working-directory: "cli" | ||
| run: yarn | ||
| - name: Check link |
There was a problem hiding this comment.
| - name: Check link | |
| - name: Run linter |
README.md
Outdated
| [](https://join.slack.com/t/k8s-kamus/shared_invite/enQtODA2MjI3MjAzMjA1LThlODkxNTg3ZGVmMjVkOTBhY2RmMmRjOWFiOGU2NzQ1ODU4ODNiMDJiZTE5ZTY4YmRiOTM3MjI0MDc0OGFkN2E) | ||
| [](https://twitter.com/intent/tweet?text=Checkout%20Kamus%20secret%20encryption%20for%20Kubernetes&url=https://github.com/Soluto/kamus&via=SolutoEng&hashtags=kubernetes,devops,devsecops) [](https://circleci.com/gh/Soluto/kamus) | ||
| [](https://twitter.com/intent/tweet?text=Checkout%20Kamus%20secret%20encryption%20for%20Kubernetes&url=https://github.com/Soluto/kamus&via=SolutoEng&hashtags=kubernetes,devops,devsecops) | ||
| [](https://circleci.com/gh/Soluto/kamus) |
There was a problem hiding this comment.
Isn't it time to remove circle ci?
| @@ -1,106 +0,0 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
There was a problem hiding this comment.
Deleting this file means you cannot easily run the e2e tests locally... I would re-consider it 🙏
There was a problem hiding this comment.
The file doesn't seem to be fit for running the tests locally at the moment. It relies on a lot of stuff happening in the CI pipeline. I agree we should keep it to allow for this functionality but I also think an issue should be opened to make local tests easier. WDYT @omerlh ?
There was a problem hiding this comment.
I think this is the only thing that relies on CI load image-archive docker-cache-api/crd-controller.tar which can be fixed... The rest is env vars. So basically a README on how to run it locally vs moving it to GH action syntax which I think you can't run locally
3 participants
No description provided.