Feat/72 automatic archive folder by DominikDab341 · Pull Request #129 · Solvro/backend-testownik

DominikDab341 · 2026-01-23T23:14:46Z

Użyłem sygnałów do tworzenia archiwum dla każdego nowego użytkownika. Każdy folder ma status - "regular" lub "archive" i na podstawie tego użytkownik może przeprowadzać jakieś operacje, dopisałem dla wygody frontendu endpoint move-to-archive. Napisałem do tego proste testy, mam nadzieję, że nie zapomniałem o żadnym casie. Wyszedłem z założenia, że do archiwum nie możemy dodawać podfolderów. Wrzucamy tam wyłącznie quizy.

Important

Introduces automatic archive folder creation for new users and adds functionality to move quizzes to an archive folder with necessary validations and tests.

Behavior:
- Automatically creates an archive folder for each new user using post_save signal in signals.py.
- Adds move-to-archive endpoint in views.py to move quizzes to the archive folder.
- Archive folders cannot have subfolders or be renamed, moved, or deleted.
Models:
- Adds Type class in models.py for folder types (ARCHIVE, REGULAR).
- Adds folder_type field to Folder model with a unique constraint for one archive per user.
Serializers:
- Updates FolderSerializer to include folder_type and add validation for archive folder restrictions.
- Adds validate_parent_id in MoveFolderSerializer to prevent moving folders into archive.
Tests:
- Adds test_folder_archive.py to test archive folder creation, restrictions, and quiz archiving.
Migrations:
- Adds migrations to introduce folder_type field and rename it to folder_type in Folder model.

^{This description was created by}^{for 6ad1b03. You can customize this summary. It will automatically update as commits are pushed.}

DominikDab341 · 2026-01-23T23:32:43Z

Problem z lintem był taki, że zapomniałem usunąć komentarza jak naprawiałem błąd w signals.py i drugi podczas importu do zarejestrowania sygnału w apps.py. Użyłem komentarza, który informuje linter o tym, żeby ignorował tą linijkę.

Antoni-Czaplicki

fajna PR, drobne komentarze tylko

Antoni-Czaplicki · 2026-01-25T19:48:19Z

quizzes/migrations/0014_rename_type_folder_folder_type.py

+            old_name='type',
+            new_name='folder_type',


hej, czemu nie po prostu type? jak już mamy obiekt folder to wiemy że to filder

Ponieważ type to funkcja w pythonie i stwierdziłem, że możę lepiej będzie to trochę uszczegółowić.

Antoni-Czaplicki · 2026-01-25T19:49:27Z

quizzes/models.py

+    class Type(models.TextChoices):
+        ARCHIVE = "ARCHIVE", "Archive"
+        REGULAR = "REGULAR", "Regular"
+


można by to nazwać FolderType i dać na góre pliku

Antoni-Czaplicki · 2026-01-25T19:50:20Z

quizzes/signals.py

+    Creates archive folder for each new user
+    """
+    if created:
+        Folder.objects.create(name="Archive", owner=instance, folder_type=Folder.Type.ARCHIVE)


nazwałbym to jednak po polsku bo będzie wyświetlane w UI

Antoni-Czaplicki · 2026-01-25T19:51:36Z

quizzes/models.py

+        ARCHIVE = "ARCHIVE", "Archive"
+        REGULAR = "REGULAR", "Regular"


fajnie jakby sam typ był zapisywany z małej żeby pasowało do innych rzeczy w bazie

Suggested change

ARCHIVE = "ARCHIVE", "Archive"

REGULAR = "REGULAR", "Regular"

ARCHIVE = "archive", "Archive"

REGULAR = "regular", "Regular"

Antoni-Czaplicki · 2026-01-25T19:53:12Z

README.md

   pip install -r requirements.txt
   ```
-
+   


to raczej przez przypadek

Copilot

Pull request overview

This PR adds first-class support for per-user quiz archive folders, enforced at the model, serializer, view, and signal layers, together with dedicated tests.

Changes:

Introduces a folder_type field on Folder (with ARCHIVE and REGULAR types) and migrations to support it.
Adds automatic creation of an Archive folder for each new user via a Django signal, and enforces archive-specific rules (no subfolders, cannot move/rename/delete archive folders) in serializers and views.
Adds a move-to-archive quiz endpoint plus a comprehensive test suite (test_folder_archive.py) validating archive creation, constraints, and quiz-moving behavior.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
`quizzes/views.py`	Adds `move_to_archive` action on `QuizViewSet` and enforces archive folder immutability in `FolderViewSet` (`perform_destroy`, `move`), including appropriate HTTP statuses.
`quizzes/tests/test_folder_archive.py`	Introduces tests covering quiz archive behavior, signal-driven archive creation, archive folder protections, cross-user isolation, and allowed operations on regular folders.
`quizzes/signals.py`	Adds a `post_save` signal handler to automatically create an `Archive` folder for each newly created `User`.
`quizzes/serializers.py`	Extends `FolderSerializer` with `folder_type` (read-only) and validation preventing archive subfolders/rename, and updates `MoveFolderSerializer` to forbid moving folders into archive folders.
`quizzes/models.py`	Adds `Folder.Type` choices and a `folder_type` field on `Folder`, defaulting to `REGULAR`, to model archive vs regular folders.
`quizzes/migrations/0013_folder_type.py`	Schema migration adding a `type` field to `Folder` to store folder type choices with default `REGULAR`.
`quizzes/migrations/0014_rename_type_folder_folder_type.py`	Follows up by renaming the `Folder.type` field to `folder_type` to align with the updated model.
`quizzes/apps.py`	Wires the quizzes app `ready()` hook to import `signals`, ensuring archive-folder creation is active.
`README.md`	Minor whitespace tweak in the setup instructions section (no functional impact).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Antoni-Czaplicki · 2026-01-25T20:02:02Z

quizzes/models.py

    updated_at = models.DateTimeField(auto_now=True)
+    folder_type = models.CharField(max_length=10, choices=Type.choices, default=Type.REGULAR)

    class Meta:


można by dodać jeszcze walidacje że nie da się utworzyć więcej niż jednego archiwum

możesz użyć https://docs.djangoproject.com/en/6.0/ref/models/constraints/

…rchive-folder

DominikDab341 · 2026-02-07T13:21:02Z

Zastosowałem się do poprawek, miałem problem z migracjami bo mój branch był trochę w plecy względem mastera ale jakoś się udało to naprawić.

Antoni-Czaplicki · 2026-02-08T19:40:03Z

dobra to ja ogarne zaraz

Antoni-Czaplicki · 2026-02-08T20:21:08Z

Putting on hold until library design is finalized

DominikDab341 added 3 commits January 23, 2026 14:01

feat: add automatic archive folder

699c36a

feat: add Archive folder protection and validation

e3dc409

refactor: move Archive validation from ViewSet to serializers

d78da12

DominikDab341 requested a review from MoonPrincess06 as a code owner January 23, 2026 23:14

pull-request-size bot added the size/L label Jan 23, 2026

refactor: lint problems

8962e6e

Antoni-Czaplicki requested changes Jan 25, 2026

View reviewed changes

Antoni-Czaplicki requested a review from Copilot January 25, 2026 19:53

Copilot started reviewing on behalf of Antoni-Czaplicki January 25, 2026 19:53 View session

Copilot AI reviewed Jan 25, 2026

View reviewed changes

Antoni-Czaplicki reviewed Jan 25, 2026

View reviewed changes

DominikDab341 added 5 commits February 7, 2026 12:35

refactor: move Type class and update naming

bdde7fe

feat: add unique constraint for archive folder type

fbaa404

fix: correct Type imports

0002867

Merge remote-tracking branch 'origin/master' into feat/72-automatic-a…

2d65e43

…rchive-folder

fix: resolve migration conflict and update archive endpoints tests

6ad1b03

DominikDab341 requested a review from Antoni-Czaplicki February 7, 2026 13:19

Antoni-Czaplicki marked this pull request as draft February 8, 2026 20:09

DominikDab341 linked an issue Feb 19, 2026 that may be closed by this pull request

Folder usuniętych #72

Open

		ARCHIVE = "ARCHIVE", "Archive"
		REGULAR = "REGULAR", "Regular"

Conversation

DominikDab341 commented Jan 23, 2026 • edited by ellipsis-dev bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DominikDab341 commented Jan 23, 2026

Uh oh!

Antoni-Czaplicki left a comment

Choose a reason for hiding this comment

Uh oh!

Antoni-Czaplicki Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

DominikDab341 Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

Antoni-Czaplicki Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

Antoni-Czaplicki Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

Antoni-Czaplicki Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

Antoni-Czaplicki Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Antoni-Czaplicki Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

DominikDab341 commented Feb 7, 2026

Uh oh!

Antoni-Czaplicki commented Feb 8, 2026

Uh oh!

Antoni-Czaplicki commented Feb 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

DominikDab341 commented Jan 23, 2026 •

edited by ellipsis-dev bot

Loading