Feat/117 quiz library endpoint by WiktorGruszczynski · Pull Request #144 · Solvro/backend-testownik

WiktorGruszczynski · 2026-02-08T01:26:28Z

Done. Dodałem model SharedFolder analogiczny jak SharedQuiz. Napisałem testy.

Response z endpointu /library/

LibraryItem - to poprostu quiz albo folder.

/library - zwraca itemy które należą do użytkownika i nie są w żadnym folderze, są udostępnione przez innego użytkownika i albo u niego nie znajdują się w żadnym folderze lub znajdują się w folderze do którego użytkownik nie ma dostępu
/library/{folder_id} - analogicznie jak wyżej, różnica taka że możemy sobie wybrać do którego folderu się ograniczamy

Testy - (nawet przechodzą)

Important

Add library endpoints to retrieve user-specific folders and quizzes, introducing SharedFolder model for sharing logic.

Endpoints:
- Adds /library/ and /library/{folder_id} endpoints in views.py to retrieve library items based on user ownership and sharing permissions.
Models:
- Adds SharedFolder model in models.py to handle folder sharing with users and study groups.
Serializers:
- Adds LibraryItemSerializer in serializers.py to serialize folders and quizzes for library endpoints.
Tests:
- Adds test_library_endpoint.py to test new library endpoints, including access control and item retrieval.
URLs:
- Updates urls.py to include new library endpoints.

^{This description was created by}^{for 149b73e. You can customize this summary. It will automatically update as commits are pushed.}

quizzes/views.py

Copilot

Pull request overview

Adds a new “library” API for listing quizzes and folders visible to a user (owned + shared), including root-level listing and folder-scoped listing. Introduces a SharedFolder model analogous to SharedQuiz and adds endpoint-level tests.

Changes:

Added /library/ and /library/<folder_id>/ endpoints with visibility logic for owned and shared folders/quizzes.
Introduced SharedFolder model + migration to represent folder sharing (user or study group).
Added LibraryItemSerializer and a test suite for the new library endpoints.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
`quizzes/views.py`	Implements the new library endpoints and visibility rules for folders/quizzes.
`quizzes/urls.py`	Adds routes for `/library/` and `/library/<uuid:folder_id>/`.
`quizzes/tests/test_library_endpoint.py`	Adds tests for library root + folder access behavior.
`quizzes/serializers.py`	Adds a polymorphic-ish serializer for returning either a folder or a quiz as a “library item”.
`quizzes/models.py`	Adds `SharedFolder` model to represent folder sharing.
`quizzes/migrations/0017_sharedfolder.py`	Creates the `SharedFolder` table.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

quizzes/views.py

quizzes/tests/test_library_endpoint.py

Copilot · 2026-02-08T01:31:01Z

quizzes/models.py

+class SharedFolder(models.Model):
+    id = models.UUIDField(primary_key=True, default=uuid.uuid4, editable=False)
+    folder = models.ForeignKey(Folder, on_delete=models.CASCADE, related_name="shares")
+    user = models.ForeignKey(User, on_delete=models.CASCADE, null=True, blank=True, related_name="shared_folders")
+    study_group = models.ForeignKey(
+        StudyGroup, on_delete=models.CASCADE, null=True, blank=True, related_name="shared_folders"
+    )
+    allow_edit = models.BooleanField(default=False)


SharedFolder allows rows where both user and study_group are NULL (or both set), which makes the share ambiguous/ineffective and can lead to confusing permission behavior. Add a DB-level CheckConstraint to enforce exactly one of (user, study_group) is set, and consider UniqueConstraint(s) to prevent duplicate shares per (folder,user) / (folder,study_group).

@WiktorGruszczynski wdg mnie słuszna uwaga

quizzes/views.py

quizzes/serializers.py

quizzes/views.py

MoonPrincess06

jakbyś tylko mógł jeszcze zadbać o to, żeby nie było możliwe duplikowanie udostępnień tzn uniqueness dla (folder, user) (folder, study_group) to byłoby super:) I zerknij może na opis tego issue którego skomentowałam

MoonPrincess06 · 2026-02-08T19:30:20Z

quizzes/models.py

+class SharedFolder(models.Model):
+    id = models.UUIDField(primary_key=True, default=uuid.uuid4, editable=False)
+    folder = models.ForeignKey(Folder, on_delete=models.CASCADE, related_name="shares")
+    user = models.ForeignKey(User, on_delete=models.CASCADE, null=True, blank=True, related_name="shared_folders")
+    study_group = models.ForeignKey(
+        StudyGroup, on_delete=models.CASCADE, null=True, blank=True, related_name="shared_folders"
+    )
+    allow_edit = models.BooleanField(default=False)


@WiktorGruszczynski wdg mnie słuszna uwaga

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-08T19:49:42Z

quizzes/views.py

+    def get(self, request):
+        user = request.user
+        items = list(self.get_toplevel_folders(user)) + list(self.get_toplevel_quizzes(user))
+


The response ordering isn’t actually created_at-desc across all library items: folders are ordered internally, quizzes are ordered internally, then the two lists are concatenated, which breaks global ordering. If clients rely on a single timeline sort, sort the combined items list by created_at (or use a DB-level UNION/annotation) before serializing.

Suggested change

items.sort(key=lambda item: item.created_at, reverse=True)

Copilot · 2026-02-08T19:49:42Z

quizzes/views.py

+        items = list(self.get_subfolders(user, folder_id)) + list(self.get_quizzes(user, folder_id))
+        return Response(LibraryItemSerializer(items, many=True, context={"request": request}).data)


Same as in the root view: subfolders and quizzes are each ordered by created_at, but concatenating the two lists breaks a global created_at sort. Consider sorting the combined items list by created_at before serializing so the folder view matches the advertised ordering.

Copilot · 2026-02-08T19:49:42Z

quizzes/serializers.py

+class LibraryItemSerializer(serializers.Serializer):
+    def to_representation(self, instance):
+        user = self.context["request"].user
+
+        if isinstance(instance, Folder):
+            return {
+                "id": instance.id,
+                "name": instance.name,
+                "type": "folder",
+                "is_shared": (instance.owner_id != user.id),
+                "created_at": instance.created_at,
+            }
+
+        if isinstance(instance, Quiz):
+            return {
+                "id": instance.id,
+                "title": instance.title,
+                "type": "quiz",
+                "is_shared": (instance.maintainer_id != user.id),
+                "created_at": instance.created_at,
+            }
+
+        return super().to_representation(instance)


LibraryItemSerializer defines no explicit fields and only overrides to_representation(). This makes the response schema hard/impossible for drf-spectacular to infer (and removes any type/format guarantees for id/created_at), so /library endpoints will likely show up as an untyped/empty object in OpenAPI. Consider defining explicit serializer fields (even if some are optional) or annotating the views with @extend_schema(responses=...) to document the union shape.

Antoni-Czaplicki · 2026-02-08T20:20:56Z

Putting on hold until library design is finalized

WiktorGruszczynski requested a review from MoonPrincess06 as a code owner February 8, 2026 01:26

Copilot AI review requested due to automatic review settings February 8, 2026 01:26

pull-request-size bot added the size/L label Feb 8, 2026

Copilot started reviewing on behalf of WiktorGruszczynski February 8, 2026 01:27 View session

WiktorGruszczynski linked an issue Feb 8, 2026 that may be closed by this pull request

[FEATURE] Endpointy to wyświetlania quizów w bibliotece #117

Open

github-code-quality bot found potential problems Feb 8, 2026

View reviewed changes

quizzes/views.py Fixed Show fixed Hide fixed

Copilot AI reviewed Feb 8, 2026

View reviewed changes

MoonPrincess06 requested changes Feb 8, 2026

View reviewed changes

WiktorGruszczynski added 4 commits February 8, 2026 20:44

feat: add SharedFolder model

ab9fef9

feat: add library endpoints

01cfd17

feat: add tests

5cd1571

fix: optimize code

149b73e

Copilot AI review requested due to automatic review settings February 8, 2026 19:45

Antoni-Czaplicki force-pushed the feat/117-quiz-library-endpoint branch from d454d6f to 149b73e Compare February 8, 2026 19:45

Copilot started reviewing on behalf of Antoni-Czaplicki February 8, 2026 19:45 View session

Copilot AI reviewed Feb 8, 2026

View reviewed changes

Antoni-Czaplicki marked this pull request as draft February 8, 2026 20:10

MarvinRucinski linked an issue Feb 19, 2026 that may be closed by this pull request

Dodać endpoint do zarządzania pytaniami #121

Closed

MarvinRucinski removed a link to an issue Feb 19, 2026

Dodać endpoint do zarządzania pytaniami #121

Closed

		items = list(self.get_subfolders(user, folder_id)) + list(self.get_quizzes(user, folder_id))
		return Response(LibraryItemSerializer(items, many=True, context={"request": request}).data)

Conversation

WiktorGruszczynski commented Feb 8, 2026 • edited by ellipsis-dev bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

MoonPrincess06 Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MoonPrincess06 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MoonPrincess06 Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Antoni-Czaplicki commented Feb 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

WiktorGruszczynski commented Feb 8, 2026 •

edited by ellipsis-dev bot

Loading

MoonPrincess06 left a comment •

edited

Loading