feat: create smoke tests by tomasz-trela · Pull Request #1045 · Solvro/mobile-topwr

tomasz-trela · 2026-03-01T15:05:28Z

Important

Introduces smoke tests and updates CI workflow for iOS integration testing, with code adjustments for test support.

CI Workflow:
- Updates .github/workflows/flutter_ci.yaml to include iOS integration tests using a simulator.
- Adds steps to install git-crypt and unlock secrets for testing.
Smoke Tests:
- Adds integration_test/smoke_test.dart with multiple end-to-end tests for different views like HomeView, BuildingsView, etc.
- Uses mock repositories for PreferredLanguageRepository, BranchRepository, and LocalChangelogRepository.
Code Adjustments:
- Adds verticalScrollableKey to MyAppConfig in ui_config.dart for consistent scrollable widget identification.
- Adds AwesomeDioInterceptor to dio_client.dart for enhanced logging in debug mode.
- Ensures ref.mounted checks in departments_repository.dart and pop_scope_coordinator.dart to prevent errors during unmounted state.

^{This description was created by}^{for fde3493. You can customize this summary. It will automatically update as commits are pushed.}

.github/workflows/flutter_ci.yaml

tomasz-trela · 2026-03-02T14:26:24Z

There is failing check because parkings are down

tomasz-trela · 2026-03-02T14:26:50Z

But yesterday test was passing

simon-the-shark

good job, good job. if you don't want to expand tests now, we can add all this as followup tasks on the board

simon-the-shark · 2026-03-02T18:55:31Z

.github/workflows/flutter_ci.yaml


    steps:
-      - uses: actions/checkout@v6
+      - uses: actions/checkout@v4


simon-the-shark · 2026-03-02T18:56:59Z

.github/workflows/flutter_ci.yaml

+      - name: Pre-build iOS Integration Test App
+        run: flutter build ios --debug --no-codesign --simulator
+
+      - name: Boot iOS Simulator
+        run: |
+          set +e 
+          DEVICE_UUID=$(xcrun simctl list devices available | grep "iPhone" | head -n 1 | awk -F'[()]' '{print $2}')
+          set -e
+
+          if [ -z "$DEVICE_UUID" ]; then
+            exit 1
+          fi
+
+          xcrun simctl boot "$DEVICE_UUID" || true
+          xcrun simctl bootstatus "$DEVICE_UUID"
+          echo "SIMULATOR_ID=$DEVICE_UUID" >> $GITHUB_ENV
+
+      - name: Run Integration Tests on iOS Simulator
+        run: flutter test integration_test/smoke_test.dart -d "$SIMULATOR_ID" --timeout=30m
+        timeout-minutes: 45


since it's taking 20+ minutes, let's separate all-checks from integrations-tests maybe so it can run in parallel (can be same file and workflow, just separate jobs)?

yes it's good idea

simon-the-shark · 2026-03-02T19:05:49Z

integration_test/smoke_test.dart

how about AboutUsView, CalendarView, NewsListView, SksMenuScreen, SksFavouriteDishesView, SettingsView :))) ?

It's good idea for next task

simon-the-shark · 2026-03-02T19:06:33Z

integration_test/smoke_test.dart

there's also obv digital guide but no need to do it now, you can add it to backlog as followup task for someone in the future

simon-the-shark · 2026-03-02T19:07:17Z

integration_test/smoke_test.dart

+    testWidgets("DeparmentsView smoke test", (tester) async {
+      await app.main(overrides: createPopupProviderOverrides());
+      await tester.pumpAndSettle();
+
+      await tapNavButton(tester, NavBarEnum.navigation);
+      await tester.pump(const Duration(seconds: 3)); // there pumpAndSettle never ends on NavigationView
+
+      final navButton = find.byKey(NavigationTabViewConfig.departments);
+      await tester.tap(navButton);
+
+      await tester.pumpAndSettle();
+
+      final errorFinder = find.byType(MyErrorWidget);
+      final scrollableFinder = find.byKey(MyAppConfig.verticalScrollableKey);
+      await scrollAndFailIfFound(tester: tester, scrollableFinder: scrollableFinder, targetFinder: errorFinder);
+      await tester.pumpAndSettle();
+      await tester.pump(const Duration(seconds: 3));
+    });


for the list views, we could consider also clicking on a random item on the list and seeing if it hadn't crashed as well. wdyt?

It's good idea for next task

tomasz-trela self-assigned this Mar 1, 2026

pull-request-size bot added the size/L label Mar 1, 2026

github-advanced-security bot found potential problems Mar 1, 2026

View reviewed changes

.github/workflows/flutter_ci.yaml Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Mar 1, 2026

View reviewed changes

.github/workflows/flutter_ci.yaml Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Mar 1, 2026

View reviewed changes

.github/workflows/flutter_ci.yaml Fixed Show fixed Hide fixed

tomasz-trela force-pushed the chore/setup-patrol branch from 7b88297 to 4a6f8e5 Compare March 1, 2026 18:18

simon-the-shark force-pushed the main branch 3 times, most recently from 0806722 to d0a34bd Compare March 1, 2026 23:31

tomasz-trela added 21 commits March 2, 2026 13:33

chore: setup patrol tests

939ccda

chore: remove patrol

8084448

feat: remove patrol and create smoke test

cb8bf89

feat: more tests

0e27fde

feat: new tests

7f32a43

chore: fixes

3d9a721

chore: remove patrol

3c1da8f

fix: fix tests

cb15fbf

fix: radio

dd698b7

feat: add integration tests on Android Emulator

a9caf97

chore: ci

493b6c7

chore: test ci

3b7fb71

chore: test ci

0a9daaf

chore: test ci faster

018c166

chore: test tests

4fa141f

chore: test ci

deb3837

chore: test ci

548c65b

chore: run ci

daf26c6

chore: test ci

d641437

chore: test ci

a8a22ff

chore: test ci

561ec55

tomasz-trela added 9 commits March 2, 2026 13:33

chore: final ci check

bd19446

chore: test ci

0ff9120

chore: test ci

34b9dc3

chore: test ci

c695ce9

chore: change timeout for ci

df846a7

chore: test ci

e5e32bc

chore: test ci

ff645fa

chore: test ci

9b1fdd3

refactor: integration tests

fde3493

tomasz-trela force-pushed the chore/setup-patrol branch from cc7d97a to fde3493 Compare March 2, 2026 12:34

tomasz-trela marked this pull request as ready for review March 2, 2026 14:25

tomasz-trela requested a review from simon-the-shark March 2, 2026 14:26

simon-the-shark reviewed Mar 2, 2026

View reviewed changes

feat: meet pr req

4ee7883

Conversation

tomasz-trela commented Mar 1, 2026 • edited by ellipsis-dev bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tomasz-trela commented Mar 2, 2026

Uh oh!

tomasz-trela commented Mar 2, 2026

Uh oh!

simon-the-shark left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tomasz-trela commented Mar 1, 2026 •

edited by ellipsis-dev bot

Loading