Skip to content

Pull Request: Add Azure AD App Configuration Documentation#23

Open
aollivierre wants to merge 8 commits intoSorenLundt:mainfrom
aollivierre:main
Open

Pull Request: Add Azure AD App Configuration Documentation#23
aollivierre wants to merge 8 commits intoSorenLundt:mainfrom
aollivierre:main

Conversation

@aollivierre
Copy link

Description

This PR adds detailed documentation for Azure AD application configuration, helping users avoid authentication issues and providing a more secure way to interact with Microsoft Graph API.

Changes Made

  1. Added new file: AZURE_APP_CONFIGURATION.md

    • Comprehensive guide for Azure AD app setup
    • Step-by-step configuration instructions
    • Troubleshooting common issues
    • Best practices and security recommendations
  2. Modified WinGet-WrapperImportFromCSV.ps1

    • Updated ClientID parameter documentation
    • Made ClientID parameter more flexible for custom app IDs

Why is this needed?

Recent changes in Microsoft's infrastructure and security policies have made it necessary to provide clear guidance on:

  • Creating and configuring custom Azure AD applications
  • Proper authentication setup for Microsoft Graph API
  • Avoiding common authentication issues
  • Following security best practices

Testing Done

  • Verified all configuration steps in a test environment
  • Confirmed authentication works with custom app ID
  • Tested both parameter passing and direct script modification
  • Validated all troubleshooting scenarios

Checklist

  • Documentation is clear and comprehensive
  • All steps are accurately described
  • Troubleshooting section covers common issues
  • Best practices are included
  • Links to official Microsoft documentation are provided

Related Issues

Closes #[Issue number] (Reference to the issue about authentication problems)

Screenshots

[You can add screenshots of the Azure portal configuration steps here]

configforgelabs and others added 7 commits June 27, 2024 22:05
I've created a comprehensive `AZURE_APP_CONFIGURATION.md` file that covers:

1. Background and reasons for using a custom app ID
2. Step-by-step instructions for creating and configuring the Azure AD application
3. How to update the scripts with the new app ID
4. Common troubleshooting issues and solutions
5. Best practices for security and maintenance
6. Required roles and permissions
7. Additional resources for further reading

The documentation is structured to be both beginner-friendly and detailed enough for experienced administrators. It includes all the issues we encountered and their solutions, as well as additional potential problems users might face.
@SorenLundt SorenLundt self-assigned this Feb 5, 2025
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@InnovationForge-com
Hi, and sorry for no input on your great work here!

I see that in general this commit has a lot of diff lines due to changing from using " to use ' in most code.
Could you review this only change relevant parts ?

This would make it easier to review the actual code changed and be able to merge into main branch

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,
I changed ' back to " with Claude in VSC. Looks good to me.
I won't change back the improved spacing formatting though. Because of this there are still many changes shown that are not actually code improvements.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed in my fork the .exe and put a .cmd instead.
Copied it from https://github.com/Micke-K/IntuneManagement. So should be working for everyone.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@InnovationForge-com
Hi, and sorry for no input on your great work here!

I see that in general this commit has a lot of diff lines due to changing from using " to use ' in most code.
Could you review this only change relevant parts ?

This would make it easier to review the actual code changed and be able to merge into main branch

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,
I changed ' back to " with Claude in VSC. Looks good to me.
I won't change back the improved spacing formatting though. Because of this there are still many changes shown that are not actually code improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants