MMA-10748 Update to meet new v1.694 Plugin Manager requirements#36
Merged
emiliangrecu merged 2 commits intomasterfrom Feb 20, 2026
Merged
MMA-10748 Update to meet new v1.694 Plugin Manager requirements#36emiliangrecu merged 2 commits intomasterfrom
emiliangrecu merged 2 commits intomasterfrom
Conversation
DirectAdmin v1.694 now requires a plugin.conf with a static id
Remove plugin.conf custom handling based on plugin.conf.new template Make install.sh executable so install on v1.694 does not crash with 500
dbistriceanu
changed the title
There was a problem hiding this comment.
Pull request overview
This PR updates the plugin's installation and configuration scripts to comply with DirectAdmin Plugin Manager v1.694 requirements, primarily focusing on standardizing code formatting and simplifying the update process by removing dynamic plugin.conf management.
Changes:
- Removed semicolons and standardized spacing in bash scripts for consistency
- Eliminated dynamic plugin.conf update logic during plugin updates
- Changed plugin.conf.new to use hardcoded plugin ID instead of template placeholder
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/update.sh | Removed plugin.conf version/URL update logic and cleaned up formatting with consistent spacing |
| scripts/uninstall.sh | Standardized indentation in conditional blocks |
| scripts/install.sh | Removed semicolons, fixed spacing, and eliminated plugin.conf.new move operation |
| plugin.conf.new | Changed from template with <PLUGINNAME> placeholder to hardcoded 'prospamfilter' ID and removed quotes from name |
| .gitattributes | Updated export-subst attribute from plugin.conf.new to plugin.conf |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
emiliangrecu
approved these changes
Feb 20, 2026
ciprian-macovei
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://docs.directadmin.com/changelog/version-1.694.html#changes-to-plugins-uploaded-with-plugin-manager