Build: Switch from -Xjvm-default=all-compatibility to -Xjvm-default=all#175
Merged
Build: Switch from -Xjvm-default=all-compatibility to -Xjvm-default=all#175
-Xjvm-default=all-compatibility to -Xjvm-default=all#175Conversation
…t=all` So the Kotlin compiler longer generates the (unnecessary) DefaultImpls classes for new interfaces. Existing interfaces are annotated with JvmDefaultWithCompatibility to preserve backwards compatibility. The bump to our Kotlin dependency was required because JvmDefaultWithCompatibility was only introduced with Kotlin 1.6. But since we were compiling with 1.6 as our target, we were implicitly depending on that already anyway. Co-authored-by: Jonas Herzig <jonas@spark-squared.com>
Traben-0
approved these changes
Mar 12, 2026
Traben-0
left a comment
Traben-0
left a comment
There was a problem hiding this comment.
lgtm, seems to tag all the interfaces it should be tagging, e.g ones with default impls
Johni0702
added a commit
that referenced
this pull request
Mar 12, 2026
…` to `all` With #175, Elementa now uses `-Xjvm-default=all`, so we no longer need to explicitly mark new interfaces with `JvmDefaultWithoutCompatibility`. We don't need to mark anything with `JvmDefaultWithCompatibility` because both, `statev2` and `layoutdsl`, projects are still considered unstable, so we don't care about their ABI changing. Source-Commit: fb810b4ef95f641bd02d9493312c9743025b45b2
Johni0702
added a commit
that referenced
this pull request
Mar 12, 2026
…` to `all` With #175, Elementa now uses `-Xjvm-default=all`, so we no longer need to explicitly mark new interfaces with `JvmDefaultWithoutCompatibility`. We don't need to mark anything with `JvmDefaultWithCompatibility` because both, `statev2` and `layoutdsl`, projects are still considered unstable, so we don't care about their ABI changing. (We were already using `all` in Elementa's build script, just not in Essential's version of these projects, hence why this doesn't actually modify the build script.) Source-Commit: fb810b4ef95f641bd02d9493312c9743025b45b2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So the Kotlin compiler no longer generates the (unnecessary) DefaultImpls classes for new interfaces.
Existing interfaces are annotated with JvmDefaultWithCompatibility to preserve backwards compatibility.
The bump to our Kotlin dependency was required because JvmDefaultWithCompatibility was only introduced with Kotlin 1.6. But since we were compiling with 1.6 as our target, we were implicitly depending on that already anyway.