Skip to content

Conversation

@BenBrock
Copy link
Collaborator

This PR updates the naming to introduce the 3-phase operations in the Sparse BLAS position paper.

@BenBrock BenBrock marked this pull request as ready for review February 25, 2025 01:24
Copy link
Contributor

@spencerpatty spencerpatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but I think it needs one more name change from multiply_execute() for spgemm to multiply_compute() ...

@BenBrock
Copy link
Collaborator Author

Just updated execute -> compute. Got to head to bed, since I have an early flight tomorrow, but feel free to approve and merge this if it looks good to you.

Copy link
Contributor

@spencerpatty spencerpatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approved

@spencerpatty spencerpatty merged commit 446b583 into main Feb 25, 2025
7 checks passed
@spencerpatty spencerpatty deleted the dev/brock/update-naming branch February 25, 2025 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants