Add matrix_opt
#27
Merged
Add matrix_opt
#27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@spencerpatty Let me know what you think when you have time; still WIP. Need to figure out how to use with MKL/ArmPL. |
spencerpatty
approved these changes
Feb 26, 2025
Contributor
spencerpatty
left a comment
spencerpatty
left a comment
There was a problem hiding this comment.
Approved! LGTM -- adds matrix_opt and uses it in an spmm test and example. When we extend this, we will add our custom vendor matrix handles in public: in matrix_opt with preprocessing macros around it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matrix_optis a wrapper around a matrix view. It is an object that in addition to referencing the view, also holds implementation-dependent optimization data.