Open
Conversation
HavenTheWanderer
approved these changes
Jul 22, 2018
Contributor
HavenTheWanderer
left a comment
HavenTheWanderer
left a comment
There was a problem hiding this comment.
This all looks really good! The one thing I will say is that this service will be making a post request, not a get. A GET is usually pulling information from a database, while a POST is putting information there. Obviously, all of this will be easier to test once the API is up and running. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apply page service.
Unsure if this is the intentional functionality for now.
I get errors and no errors ever other time.