Skip to content

Comments

Dockerfile for the st spot detector#55

Open
elhb wants to merge 8 commits intoSpatialTranscriptomicsResearch:masterfrom
elhb:docker
Open

Dockerfile for the st spot detector#55
elhb wants to merge 8 commits intoSpatialTranscriptomicsResearch:masterfrom
elhb:docker

Conversation

@elhb
Copy link

@elhb elhb commented Jul 20, 2018

Tested and working 20180720.
Docker version 18.03.1-ce, build 9ee9f40
OSX High Sierra 10.13.5

@jfnavarro
Copy link
Contributor

What are the differences/advantages of the docker container over the singularity container that we already have?

@elhb
Copy link
Author

elhb commented Jul 20, 2018

just another platform, some people are more familiar with docker than singularity, more a matter of taste I think (unless you are running on HPC like uppmax, then you'd probably want singularity)

@jfnavarro
Copy link
Contributor

I think it is better that you put the container in a separate repo with installation instructions (as we did with the singularity) and then we can link to it from our README. What do you think @ludvb @elhb ?

@elhb
Copy link
Author

elhb commented Jul 20, 2018

sounds good to me

@ludvb
Copy link
Collaborator

ludvb commented Jul 20, 2018

Thanks for the PR @elhb ! I'm fine with either solution but I guess a symmetrical treatment with the singularity container makes sense. Maybe we should avoid cluttering the org page with container repos, though? As an alternative, we could merge this with the singularity container repo and update its name and readme to reflect that.

@jfnavarro
Copy link
Contributor

Merging the singularity container repo and update the documentation accordingly sounds like a good idea to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants