Skip to content

Conversation

@Useinovski
Copy link
Contributor

@Useinovski Useinovski commented Jan 16, 2026

Description

Remove the limits from the UI for /api/v2/search endpoint.

Motivation and Context

Resolves BED-6985

Why is this change required? What problem does it solve?
When using the search bar in the explore tab, the UI was setting a default Prefer header of "wait=60". This PR aims to remove this implementation.

How Has This Been Tested?

Tested via UI. No longer sets a default of 'wait=60' in the prefer header.

Screenshots (optional):

Before:
Screenshot 2026-01-16 at 11 43 46 AM
Screenshot 2026-01-16 at 11 37 47 AM

After:
Screenshot 2026-01-16 at 11 29 30 AM
Screenshot 2026-01-16 at 11 40 49 AM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Summary by CodeRabbit

  • Bug Fixes
    • Removed an unnecessary parameter from search requests to improve request handling.

✏️ Tip: You can customize this high-level summary in your review settings.

@Useinovski Useinovski self-assigned this Jan 16, 2026
@Useinovski Useinovski added api A pull request containing changes affecting the API code. user interface A pull request containing changes affecting the UI code. labels Jan 16, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 16, 2026

Walkthrough

The static Promote: 'wait=60' header has been removed from the search API request configuration in the JavaScript client library. This eliminates a hardcoded header previously sent with all search requests to the /api/v2/search endpoint.

Changes

Cohort / File(s) Summary
Search Request Configuration
packages/javascript/js-client-library/src/client.ts
Removed static Promote: 'wait=60' header from search handler's API request construction. Request params and option merging logic remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

bug

Suggested reviewers

  • sircodemane

Poem

🐰 A header bid farewell, wait=60 no more,
The search requests flow with a lighter footstep than before,
Three lines removed, the config refined and clear,
Hopping forward with code so lean, we cheer! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: removing a default timeout (wait=60) from the search endpoint, directly matching the code modification.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The PR description is comprehensive and follows the template with all required sections completed: clear description of changes, motivation/context with ticket reference (BED-6985), testing details, type of change identified, and checklist items marked complete.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Useinovski Useinovski added the bug Something isn't working label Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api A pull request containing changes affecting the API code. bug Something isn't working user interface A pull request containing changes affecting the UI code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants