fix idea sync failing on composite builds, add support for composite builds#367
Open
NikkyAI wants to merge 17 commits intoSplitties:mainfrom
Open
fix idea sync failing on composite builds, add support for composite builds#367NikkyAI wants to merge 17 commits intoSplitties:mainfrom
NikkyAI wants to merge 17 commits intoSplitties:mainfrom
Conversation
Member
|
I've seen I broke something with Kotlin plugin version by trying to fix something, I'll fix it on the main branch first. |
Member
|
@NikkyAI I fixed what I broke on the main branch, you can undo the changes you did to work that around in this PR. |
This reverts commit b5bcd87
Collaborator
Author
|
@LouisCAD i reverted the commit, kepts the plugin alias so that tests do not fail, i will remove that in a future PR when i work on integrating parent and included builds more |
Member
|
If you merge latest main again, the issue will go away. |
Collaborator
Author
|
further testing reveals this breaks in different ways.. still needs more testing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Description
handles failure due to uninitialized
versionPropertiesFileduring idea syncit does this by catching the exception and setting the description of task
refrewshVersionsto the most likely correct valuemain project and included project will have seperate
versions.properties(although if they both are configured to point at the same file it might work?)
it also refactors
RefreshVersionsConfigHolderusageusing the rootProject path as the key each uses their own
RefresVersionsConfiginstancethis avoids the parentProject writing to the included builds
versions.propertiesthe only breaking change is for groovy code:
versionForneeds to be passed the project to grab the correct config instance(works out of the box as receiver in kotlin)
unless there is a way to make these functions have a receiver without breaking usage code ?
versionForwas moved into the extensionversions, so that it can keep a reference to the correct configthe usage looks like so now:
it does not require imports in the buildscript anymore
📄 Motivation and Context
makes
includeBuildnot failthis mainly fixes the idea sync failing and removing all tasks from the tool window
should unblock work on #205
🧪 How Has This Been Tested?
tested on idea ultimate on windows and linux
all sample projects pass checks and idea sync
📦 Types of changes
✅ Checklist