Add "CR" as a stability level marker for release candidates.#676
Open
GeorgEchterling wants to merge 1 commit intoSplitties:mainfrom
Open
Add "CR" as a stability level marker for release candidates.#676GeorgEchterling wants to merge 1 commit intoSplitties:mainfrom
GeorgEchterling wants to merge 1 commit intoSplitties:mainfrom
Conversation
GeorgEchterling
changed the title
Author
|
The failing test was "BundledDependenciesTest > Version keys should be up to date() FAILED". It passes locally, I don't know why it fails in CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes #673.
Adds "CR" as a possible stability modifier for release candidates.
Why?
Hibernate uses "CR" ("Candidate Release") instead of "RC" to indicate release candidate versions. Previously, these were not properly detected.
How?
The extension method
String.findStabilityLevelin theVersionclass now matchesCRtoStabilityLevel.ReleaseCandidateinstead ofnull.Testing?
I added some of Hibernate's CR versions to
ReleaseCandidate.txt, which is used inVersionComparatorTest.testStabilityLevel. I then re-ran thechecktask in thepluginsproject.