chore: update to librespot v0.8 #1376
Closed
+667
−706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace SpotifyItemType import with SpotifyUri (removed in 0.8) - Update OpenUri to use SpotifyUri::from_uri() then convert to SpotifyId - Add Local variant to UniqueFields match (new in 0.8) - Replace deprecated to_base62() with to_id() for SpotifyUri objects
- Replace id.item_type with SpotifyUri pattern matching - Use SpotifyUri directly in Track::get() call - Match on SpotifyUri variants instead of SpotifyItemType enum
- Clone track_id since SpotifyUri doesn't implement Copy trait
|
I can testify that this works, thank! |
|
I built this from source on my ancient Banana Pi M1* and it works perfectly, resolving the recent "won't play any more" issue. Thanks for the work! * couldn't get cross-compilation working; had to create an NBD swap file from laptop RAM to get native compilation to complete after about 7 hours. |
5 tasks
Member
|
Thank you for your help, it is appreciated! Since I had a slightly different version already sitting at #1374, I modified and merged this instead, hope that is okay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade librespot to v0.8
fixes #1373