Fix react-hub installation for react 18+ #22
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds React 19 support to the @stackone/react-hub package to resolve npm installation errors in projects using React 19+. The change updates both peer dependencies and development dependencies to include React 19 compatibility.
Key changes:
- Updated
peerDependenciesto include React 19 support for bothreactandreact-dom - Upgraded development dependencies to use React 19 versions
- Added corresponding changelog entry
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updated peer dependencies and dev dependencies to support React 19, bumped package version to 1.2.0 |
| CHANGELOG.md | Added changelog entry documenting React 19 support feature |
|
|
||
| ### Features | ||
|
|
||
| * add React 19 support to peerDependencies ([#XX](https://github.com/StackOneHQ/react-hub/issues/XX)) - Added support for React 19 in peer dependencies to enable installation in projects using React 19+ |
There was a problem hiding this comment.
The changelog entry contains placeholder issue numbers ([#XX]) that should be replaced with actual issue or PR numbers before merging.
Suggested change
| * add React 19 support to peerDependencies ([#XX](https://github.com/StackOneHQ/react-hub/issues/XX)) - Added support for React 19 in peer dependencies to enable installation in projects using React 19+ | |
| * add React 19 support to peerDependencies ([#23](https://github.com/StackOneHQ/react-hub/issues/23)) - Added support for React 19 in peer dependencies to enable installation in projects using React 19+ |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add React 19 support to peer dependencies to resolve npm installation errors.
Previously,
@stackone/react-hubcould not be installed in projects using React 19+ due to anERESOLVEerror caused by conflictingpeerDependencies. This PR updates thepeerDependenciesto include React 19 andreact-dom.Slack Thread
Learn more about Cursor Agents