chore: fix tyos ignore regex #74
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes regex patterns in the typos configuration file to properly handle spellchecker ignore directives. The main fix corrects the HTML comment pattern structure, changing it from a single-comment pattern to properly match separate opening and closing comment tags.
Key Changes
- Updated regex patterns to use
[\\s\\S]*?instead of.*?\\n\\s*for more flexible matching - Fixed HTML comment pattern to correctly match separate opening (
<!-- spellchecker:off -->) and closing (<!-- spellchecker:on -->) comments - Added trailing comma for consistency in the configuration array
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
glebedel
reviewed
Dec 23, 2025
Comment on lines
1
to
10
| [default] | ||
| locale = 'en-us' | ||
| extend-ignore-re = [ | ||
| "(?s)(#|//)\\s*spellchecker:off.*?\\n\\s*(#|//)\\s*spellchecker:on", | ||
| "(?s)<!--\\s*spellchecker:off.*?\\n\\s*spellchecker:on\\s*-->", | ||
| "(?s)(#|//)\\s*spellchecker:off[\\s\\S]*?(#|//)\\s*spellchecker:on", | ||
| "(?s)<!--\\s*spellchecker:off\\s*-->[\\s\\S]*?<!--\\s*spellchecker:on\\s*-->", | ||
| "(?Rm)^.*#\\s*spellchecker:disable-line$", | ||
| "(?m)^.*<!--\\s*spellchecker:disable-line\\s*-->\\n.*$" | ||
| "(?m)^.*<!--\\s*spellchecker:disable-line\\s*-->\\n.*$", | ||
| ] | ||
|
|
||
| [files] |
Contributor
There was a problem hiding this comment.
This is over kill let's remove this whole typo.toml. Not that hard to have a aspell checker in the editor itself and considering a lot of docs will be llm driven/reviewed there's very little risk to introduce typos
glebedel
requested changes
Dec 23, 2025
Contributor
glebedel
left a comment
glebedel
left a comment
There was a problem hiding this comment.
we should remove the typos.toml / action checker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Updated typos.toml ignore regex to correctly skip sections wrapped with spellchecker:off/on in code and HTML comments, even across multiple lines. This reduces false positives from typos checks in disabled blocks.
Written for commit 0d410c8. Summary will update automatically on new commits.