feat: contribution of new py-amqp/asyncio based sensor, bump to v1.2.0#22
feat: contribution of new py-amqp/asyncio based sensor, bump to v1.2.0#22ip-sf wants to merge 2 commits intoStackStorm-Exchange:masterfrom
Conversation
|
Unsurprisingly, the Test job failed. jobs:
build_and_test:
runs-on: ubuntu-20.04
# When parent workflow is named "Build and Test" this shows up as:
# "Build and Test / Python 3.6"
name: 'Python ${{ matrix.python-version-short }}'
strategy:
matrix:
include:
- python-version-short: "3.6"
python-version: 3.6.13Testing via 3.6, Stackstorm running 3.8. |
|
Execution log |
arm4b
left a comment
There was a problem hiding this comment.
Thanks for contributing it! Some nicely written code! 👍
We however can't merge it so far as it's failing CI on py3.6 which is still supported by st2 (because we support U18 which comes with py3.6).
As we'll drop py3.6 in the future releases we could merge it later.
But anyways it's something that should be helpful to other folks. Keeping it open.
|
@armab Understood on py3.6. Im not familiar with U18 (and my google-fu is failing me), could you provide a link that lets me learn more? Thanks! |
|
Some of the Python3 support versioning discussions are availble here: StackStorm/community#103 and StackStorm/community#115 (comment) |

A direct result of StackStorm/st2#5743
This new sensor uses only
py-amqpandasyncio(3.8), and is tested and working inside thest2sensorcontainerdocker image, when ran in eithersingle-sensor-modeor just via a singlest2sensorcontainerprocess.