Conversation
Member
|
There's also Friendship Club.app/Contents/Resources/data/data.kpf so that's not enough. But even then, doing negative lookbehinds is not exactly something I'd want to do here. |
Contributor
Author
|
Can filesize be checked somehow? In Friendship Club and Toast Time kpf files are very small, less than 1 KB. In Kex engine games they contain resources and are relatively big, 20 MB and more. |
Member
|
After running changed rules in this pull request (this bot only tests rules.ini changes): Changed technologies: Engine.Kex These apps no longer match: (1) 316660 These apps now match: (20) 2310 2320 2330 2340 9030 9040 332760 405820 405830 410710 668980 1010750 1148590 1413870 1421490 1678420 1678430 1996770 2292260 2424570 Please confirm that all these changed apps are correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief explanation of the change
Friendship Club and Toast Time have files config.kpf which make false positives for the Kex engine. This fix adds negative lookbehind to exclude those files.