FGD documentation updates #283
Conversation
…descs for prop_vehicle_choreo_generic
…ngelevel w/ credit. Improve documentation for light_environment. Remove nonexistent ents item_longjump, spraycan (per momentum + p2ce).
…riptions for hover turret. Add undocumented Dodge/FlankEnemy inputs to npc_hunter, remove nonexistent crouching/minigun inputs; document npc_hunter_maker. Update description for most HL2 weapons + magnusson device/striderbuster.
AWildErin
left a comment
AWildErin
left a comment
There was a problem hiding this comment.
A few nits, and some other comments. Additionally, I don't think a couple entities should be included here in the fgd.
prop_personality_sphere is an unfinished entity, which I don't think even functions. We don't really need to add every entity to the FGD, especially when it wasn't P2's FGD either. Realistically, I don't even think we should keep this entity around and I don't think we're going to make edits to fix it either. Additionally, it's not even a alias of prop_glados_core, despite attempting to function the same, they are separate entities.
Also, should hl2_gamerules be here? I opened the discussion of it on the internal discord, but i'll add it here too. If we had inputs like mapbase does then maybe it would be warranted but we don't. the gamerules are sort of an internal entity, but I think they are fine to spawn? (see the mp game rules for portal). Frankly, I don't see an issue with adding it, but given it adds nothing to the FGD and even just has a comment saying it's not applicable, i think it's still wise to bring it up for discussion.
Remove prop_personality_sphere, proxy entity hl2_gamerules. Fix up description of panorama_screen, genericize blob lighting pos help. Replace the word "ziplining" in help for RappelNPC input BeginRappel with "rappeling". In item_paint_power_pickup, replace the word "kind" with "type" in help for PaintType. Remove double "into" from npc_hunter, and remove mention of Episodic exclusivity from thumper sound radius help. Add game_weapon_manager spawnflag back to weapon_striderbuster, per void CWeaponStriderBuster::Launch( CBasePlayer *pPhysGunUser ). After further testing, remove variable "gametype" from info_portal_gamerules as it doesn't appear to influence anything in mp or coop gamemodes. Clarify usage of OnHostileEnteredVehicle and OnHostileExitedVehicle to specifically refer to fast zombies per npc_fastzombie.cpp, ai_behavior_passenger.cpp and ai_behavior_passenger_zombie.cpp per TF branch. Nuke unused variable m_bColdWorld from worldspawn as it is not referenced by any AI-related code per TF branch.
…visual representation for prop_mirror and copyedit prop_coreball input descriptions to prop_scalable Entities npc_hover_turret and npc_blob do not exist in P2:CE. Add visual representation of prop_mirror and clarify half-width/height mechanism like linked_portal_door. Copy description of SetScale(X/Y/Z) inputs from prop_coreball to prop_scalable.
Array of rewrites for a number of entities present in-engine and in portal2 + P2:CE that clarify and document behavior. This also removes several nonexistent entities (particularly
npc_houndeye,spraycan,item_longjump) and removes inputs/outputs that are missing from certain entities (e.g.:npc_hunter) while also adding previously undocumented I/O.This PR includes
threetwo new icons for several entities (hl2_gamerules,info_portal_gamerules,point_changelevel) created by @ashanderite.