Fix and test no segment-routing spotlight config #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented test_no_segment_routing_config() method that was marked as TODO - Fixed sensor count tracking logic to properly simulate spotlight behavior - Test now properly: 1. Re-enables spotlighting (verifies previous functionality) 2. Disables spotlighting using 'no segment-routing' command 3. Verifies correct number of sensors are deleted - All tests in the suite now pass The test simulates the difference between normal spotlight disable (which may leave some sensors) and 'no segment-routing' command (which removes ALL spotlight-related sensors)
- Documents all test methods including the newly completed no segment-routing test - Provides instructions for running tests - Explains the key differences between normal spotlight disable and no segment-routing - Includes notes for transitioning from mock to real hardware testing
Co-authored-by: nilaa567.murugaa <nilaa567.murugaa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add and fix the
test_no_segment_routing_configto verify sensor deletion when disabling spotlight with 'no segment-routing' command.The test initially failed because the mock sensor count tracking logic (
_get_sensor_countand_disable_segment_routing) did not accurately simulate the hardware behavior of sensor deletion, particularly for the "no segment-routing" command. The fix updates this logic to correctly reflect the expected sensor count changes.Open in Web • Open in Cursor • Open Docs