Refactor server to use .NET Generic Host APIs #2314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Measurity
added
Area: dev
15 tasks
Member
|
Seems like another huge piece of work and it will be hard to test/integrate. |
Measurity
force-pushed
the
server-net-host
branch
from
e86339e to
32e17bf
Compare
Test Results239 tests 238 ✅ 7s ⏱️ Results for commit 71b7a48. ♻️ This comment has been updated with latest results. |
Measurity
changed the title
Measurity
removed
the
Area: persistence
Measurity
force-pushed
the
server-net-host
branch
3 times, most recently
from
598fcfd to
467ebf3
Compare
Measurity
force-pushed
the
server-net-host
branch
5 times, most recently
from
a333b83 to
210277d
Compare
Measurity
force-pushed
the
server-net-host
branch
from
210277d to
3f27081
Compare
Measurity
force-pushed
the
server-net-host
branch
7 times, most recently
from
5348224 to
0ee1082
Compare
Now exception will be logged again under a log, if available
Added "(REDACTED)" tag to logged IPs if redacted.
Got accidentially removed during merge resolving
This is to avoid accidental paths if server is misconfigured.
This allows code to supply a logger, if interested in logs. Instead of always logging.
Collaborator
Author
|
Will merge this PR in a week from now if no review comments are made. Resetting the count when all review comments are handled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NitroxConfigin custom MS configuration provider for validation, CMD args and DI supportNitrox.Model.Logger.Log(i.e. redaction andLogOnce).server.Development.jsonwhich allows developers to override any config property. It should be generated on build if it doesn't exist. And should work with instant launch too.Missing features
We should tell users to edit config file directly, and restart server. This is because
IOptions<T>from MSDI does not have persisting built-in.Reviewing
Everything flows from
Program.StartServerAsyncso I recommend giving it a good look before reviewing the rest.I tried to compartmentalize dependencies together into extension methods on
IServiceCollection. In other words, removing.AddPackets()should still compile and run the server. It just won't have any packet related services (like LiteNetLib) running.Issues to close
Preview