Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
==========================================
- Coverage 97.06% 96.45% -0.61%
==========================================
Files 18 19 +1
Lines 2382 1777 -605
==========================================
- Hits 2312 1714 -598
+ Misses 57 48 -9
- Partials 13 15 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if upgrader == nil { | ||
| upgrader = defaultWebSocketUpgrader() | ||
| } | ||
|
|
||
| conn, err := upgrader.Upgrade(w, req, nil) |
There was a problem hiding this comment.
WebSocket upgrade fails when timeout middleware is enabled
Because WebSocket routes are run through wrapHandler, any non-zero Global/SubRouter/route timeout adds the timeout middleware, which replaces the http.ResponseWriter with mutexResponseWriter that does not implement http.Hijacker. The gorilla/websocket.Upgrader.Upgrade call here requires a Hijacker and will return websocket: response does not implement http.Hijacker, so WebSocket endpoints cannot upgrade once timeouts (or any similar middleware that wraps the writer) are configured.
Useful? React with 👍 / 👎.
Summary
Testing
Codex Task