feat: add Hijack support for WebSocket upgrades in metrics handler#106
Merged
Suhaibinator merged 1 commit intomainfrom Dec 21, 2025
Merged
feat: add Hijack support for WebSocket upgrades in metrics handler#106Suhaibinator merged 1 commit intomainfrom
Suhaibinator merged 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
=======================================
Coverage 97.48% 97.48%
=======================================
Files 18 18
Lines 1867 1872 +5
=======================================
+ Hits 1820 1825 +5
Misses 35 35
Partials 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds Hijack interface support to the metrics middleware's response writer wrapper to enable WebSocket upgrades and other connection hijacking scenarios to work properly through the metrics layer.
- Implements the
http.Hijackerinterface on theresponseWriterstruct - Delegates hijack calls to the underlying ResponseWriter when supported
- Returns
http.ErrNotSupportedfor ResponseWriters that don't support hijacking
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/metrics/handler_method.go | Adds Hijack() method to responseWriter that delegates to underlying ResponseWriter when it implements http.Hijacker |
| pkg/metrics/metrics_test.go | Adds MockHijackResponseWriter mock and two test cases covering both successful hijack and unsupported hijack scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.