Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the GitHub Actions workflow for building and publishing the Python package to PyPI.
- Updated the GitHub environment from "pypi-publish" to "pypi".
- Added a new step to extract the version from the Git tag and pass it to the build process.
| name: Build and publish Python package to PyPI | ||
| runs-on: ubuntu-latest | ||
| # NOTE: You should create a "pypi-publish" environment in GitHub repo settings | ||
| # NOTE: You should create an environment in GitHub repo settings |
There was a problem hiding this comment.
[nitpick] Consider clarifying the comment by specifying the expected environment name (e.g., 'pypi') to guide users in setting up the correct GitHub environment for PyPI publishing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.