Add support for loading custom player models#124
Open
mcy wants to merge 2 commits intoSuperDude88:mainfrom
Open
Add support for loading custom player models#124mcy wants to merge 2 commits intoSuperDude88:mainfrom
mcy wants to merge 2 commits intoSuperDude88:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a re-implementation of some work by Teotia444 from a few months ago, which teaches the randomizer how to patch files for a custom model mod.
This PR contains:
Code for doing the patching. Right now it patches Link.szs and some files for voice clips. It should probably also patch the files for the map icon, too, but I don't know what the right destination for those is.
Adds a way to select a custom model in the Aroma UI. The current mechanism is not ideal or efficient, but unless people have hundreds of models I doubt the O(n log n) overhead will be noticeable. I have made it so that you can have multiple models to choose from.
I have not updated the desktop app because I have never touched Qt anything in my life, nor do I have a Windows dev machine to test with (like I have a Windows machine but I am not comfortable building for
x86_64-pc-windows).Also, the color tab should be renamed (
Customization?) and it would be good if selecting a custom model hid the color selection stuff. I can probably code this up myself, but testing on-console right now is quite a hassle for me (it requires walking up and down a flight of stairs...).That aside, I have not observed any crashes from zipping Midna around the Great Sea for a couple of hours, so it seems to work.