chore: first commit with cdk stack for GraphQL API#22
chore: first commit with cdk stack for GraphQL API#22himabindugit wants to merge 1 commit intoSuperformula:mainfrom
Conversation
|
Hi @himabindugit, I didn't have the time to review your PR completely, but one of the requirements we had in the readme was to Write concise and clear commit messages. Can you try to do an interactive rebase to separate your work on multiple commits? Then I can continue reviewing your PR. I really appreciate the time you spent working on this pull request |
|
Hi @marcelino-sf |
@marcelino-sf alright assuming you response is Yes, pushing multiple commits with each functionality |
|
Closing this PR will open new one based on the suggestion here |
|
I have opened new PR, please ignore first commit and look into others, thank you |
|
@marcelino-sf Sorry for the confusion, here is my final PR with valid commits |
Hi @marcelino-sf
Here is my first commit for the code challenge test, please let me know if anyone have any questions, happy to hop on a zoom call for code tour.
Thanks