Skip to content

chore: first commit with cdk stack for GraphQL API#22

Closed
himabindugit wants to merge 1 commit intoSuperformula:mainfrom
himabindugit:hima-cloud-backend-test
Closed

chore: first commit with cdk stack for GraphQL API#22
himabindugit wants to merge 1 commit intoSuperformula:mainfrom
himabindugit:hima-cloud-backend-test

Conversation

@himabindugit
Copy link

Hi @marcelino-sf
Here is my first commit for the code challenge test, please let me know if anyone have any questions, happy to hop on a zoom call for code tour.

Thanks

@marcelino-sf
Copy link
Contributor

Hi @himabindugit, I didn't have the time to review your PR completely, but one of the requirements we had in the readme was to Write concise and clear commit messages. Can you try to do an interactive rebase to separate your work on multiple commits? Then I can continue reviewing your PR.

I really appreciate the time you spent working on this pull request

@himabindugit
Copy link
Author

himabindugit commented Aug 12, 2022

Hi @marcelino-sf
I did see the requirement in readme, just not to overwhelm with so many changes, I made sure all the code is working fine and pushed everything in one go to keep it simple.
Are you asking to push each file separately with the corresponding commit comment about that file? Am I reading your request correctly? Please let me know. I am happy to do that.

@himabindugit
Copy link
Author

Hi @marcelino-sf I did see the requirement in readme, just not to overwhelm with so many changes, I made sure all the code is working fine and pushed everything in one go to keep it simple. Are you asking to push each file separately with the corresponding commit comment about that file? Am I reading your request correctly? Please let me know. I am happy to do that.

@marcelino-sf alright assuming you response is Yes, pushing multiple commits with each functionality

@himabindugit
Copy link
Author

Closing this PR will open new one based on the suggestion here

@himabindugit
Copy link
Author

I have opened new PR, please ignore first commit and look into others, thank you

@himabindugit
Copy link
Author

@marcelino-sf Sorry for the confusion, here is my final PR with valid commits
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants