Skip to content

If there is not any result, server will return 404 error. #23 #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
b0nsun9 merged 1 commit into from
Feb 6, 2025
Merged

If there is not any result, server will return 404 error. #23 #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions functions/src/data/place/get/places/GetPlacesRepository.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,9 +129,7 @@ async function _GetPlacesFromGoogle(

}

const data = await response.json()

throw new Error(data)
throw new Error(response.statusText)

} catch (error) {
throw error
Expand Down
5 changes: 3 additions & 2 deletions functions/src/domain/place/get/places/GetPlacesUsecase.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,9 @@ export async function GetPlacesUsecase(request: GetPlacesUsecaseRequest | string

try {

const resultSurcharges = await GetSurchargesRepository(resultPlaceIds)
const franchisesNames = await GetFranchiseRepository()
const [resultSurcharges, franchisesNames] = await Promise.all(
[GetSurchargesRepository(resultPlaceIds), GetFranchiseRepository()]
)

const placesWithSurcharges = resultPlaces.places.map((place) => {

Expand Down
5 changes: 4 additions & 1 deletion functions/src/interface/place/get/places/getPlacesInterface.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,15 @@ export const getPlacesInterface = async (request: express.Request, response: Res
})

} catch (error: unknown) {

if (error instanceof Error) {
if (error.message === "User location is out of New Zealand") {
response.status(403).send({ message: error.message })
return
}
}
response.status(500).send({ message: error })

response.status(404).send()

}
}