Skip to content

Bug fixes #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ValShaped wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Bug fixes #3

ValShaped wants to merge 5 commits into from

Conversation

@ValShaped
Copy link

@ValShaped ValShaped commented Jul 5, 2023 •
edited
Loading

Bug Fixes:

msprobe.py:

  • Default loadaddr was left undefined unless -mc passed

assemble.py:

  • Off-by-one in assembleOneOpInstruction slice index produced incorrect machine code
  • Off-by-one in assembleRegister Indirect Source mode produced invalid register name
  • Numeric jump offsets outside valid range would be accepted
  • Jump offsets without a leading + or - would always be treated as labels since [0-9] is alphanumeric
  • Crash when parsing blank or comment-only lines
  • Invalid register encoding produced by extensionWord type error in AssembleRegister (object is string, not int)

Formatting improvement:

  • Fixed mixed spaces/tabs
  • Fixed trailing whitespace

ValShaped added 5 commits June 24, 2023 13:32
@ValShaped
Fix inconsistent whitespace
417827b
@ValShaped
Bug fixes
9186bab 
msprobe.py:
- Default loadaddr was left undefined unless `-mc` passed
assemble.py:
- Off-by-one in OneOp assembly produced incorrect machine code
- Off-by-one in Indirect mode assembly produced invalid register name
- Out-of-range relative jumps produced garbage output
@ValShaped
msprobe,py: UX Improvements
3be3b2d 
- Replace invalid instruction marker '!!!' with the invalid opcode
- Exit with a cancellation message instead of unwinding stack on SIGINT
@ValShaped
assemble.py: Alternate mnemonics
3b7ae61 
- `jnc` = `jlo`
- `jnz` = `jne`
- `jc` = `jhs`
- `jz` = `jeq`
@ValShaped
assemble.py: fix input parsing limitations with regex
f614fe4 
- Remove comments from lines before processing
  - Remove comment-stripping logic from each function
  - Skip empty/comment-only lines
- Use regex to identify relative jump offset number
  - This fixes a bug where jump offset always needed + or  -
- Use regex to split opcode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ValShaped