Skip to content

Fix: updated lower bound of MAR04356 to make it reversible#991

Open
liamkelley93 wants to merge 1 commit intoSysBioChalmers:developfrom
liamkelley93:develop
Open

Fix: updated lower bound of MAR04356 to make it reversible#991
liamkelley93 wants to merge 1 commit intoSysBioChalmers:developfrom
liamkelley93:develop

Conversation

@liamkelley93
Copy link

Main improvements in this PR:

This change fixes #990 by changing the lower bounds of reaction MAR04356 to -1000 in the model .yml file, thereby making the reaction reversible. This matches the real biology as highlighted in the issue.

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

@JHL-452b
Copy link
Collaborator

I'm not sure why the check failed, maybe you chose the wrong branch to merge? In other PRs, develop was selected instead of SysBioChalmers:develop. Maybe you can try to adjust the target branch.

@liamkelley93
Copy link
Author

@JHL-452b I selected develop from the dropdown, which then displays as SysBioChalmers:develop, so I don't know how else to do it, there are no other ones with develop in the name. Any ideas on that? I can't imagine what else could cause the error, I literally only changed the lower bound in one line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants