Skip to content

Refactor access code and token handling #1833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
samuelwei wants to merge 5 commits into
base: develop
Choose a base branch
from

Fix missing hash parameters

fe7774a
Select commit
Loading
Failed to load commit list.
Draft

Refactor access code and token handling #1833

Fix missing hash parameters
fe7774a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 1, 2025 in 1s

96.22% (+14.79%) compared to ebe8810

View this Pull Request on Codecov

96.22% (+14.79%) compared to ebe8810

Details

Codecov Report

Attention: Patch coverage is 61.53846% with 20 lines in your changes missing coverage. Please review.

Project coverage is 96.22%. Comparing base (ebe8810) to head (fe7774a).
Report is 17 commits behind head on develop.

Files with missing lines Patch % Lines
resources/js/views/RoomsView.vue 51.28% 19 Missing ⚠️
resources/js/components/RoomShareButton.vue 88.88% 1 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff               @@
##             develop    #1833       +/-   ##
==============================================
+ Coverage      81.43%   96.22%   +14.79%     
- Complexity      1410     1414        +4     
==============================================
  Files            364      364               
  Lines           9559     9622       +63     
  Branches         874      887       +13     
==============================================
+ Hits            7784     9259     +1475     
+ Misses          1775      363     -1412

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov