Refactor: Replace RoomAuthService with Laravel Context#2812
Merged
Refactor: Replace RoomAuthService with Laravel Context#2812
Conversation
Copilot
AI
changed the title
[WIP] Refactor RoomAuthService to use Laravel Context
Refactor: Replace RoomAuthService with Laravel Context
Feb 11, 2026
samuelwei
requested changes
Feb 11, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2812 +/- ##
=============================================
- Coverage 96.77% 96.76% -0.02%
+ Complexity 1851 1839 -12
=============================================
Files 445 444 -1
Lines 12601 12570 -31
Branches 2063 2063
=============================================
- Hits 12195 12163 -32
- Misses 406 407 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PILOS
|
||||||||||||||||||||||||||||
| Project |
PILOS
|
| Branch Review |
copilot/refactor-room-auth-service
|
| Run status |
|
| Run duration | 07m 27s |
| Commit |
|
| Committer | Copilot |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
613
|
| View all changes introduced in this branch ↗︎ | |
c3c811f to
3eaaf17
Compare
Co-authored-by: samuelwei <4281791+samuelwei@users.noreply.github.com> # Conflicts: # app/Http/Controllers/api/v1/RoomController.php # app/Http/Middleware/RoomAuthenticate.php # app/Http/Requests/JoinMeeting.php # app/Http/Requests/StartMeeting.php # app/Http/Resources/Room.php # app/Models/Room.php # app/Services/MeetingService.php # app/Services/RoomAuthService.php # tests/Backend/Unit/MeetingTest.php # Conflicts: # app/Http/Resources/Room.php # tests/Backend/Unit/MeetingTest.php
fd7123c to
b3090ca
Compare
samuelwei
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2811
Type
Checklist
Changes
RoomAuthServicesingleton with Laravel 12's nativeContextfeatureContext::addHidden()for storing room authentication state and tokens (excluded from logs per security requirement)Context::getHidden()AppServiceProviderapp/Services/RoomAuthService.php(99 LOC removed)Before:
After:
Other information
Net reduction of 131 lines. Context keys use pattern
room.{room_id}.{attribute}for per-room scoping.Uses
Context::getHidden()method to properly retrieve values stored withContext::addHidden(), ensuring hidden context values remain excluded from logs while maintaining proper API usage.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.