-
Notifications
You must be signed in to change notification settings - Fork 30
Migrate from npm to pnpm #2817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Migrate from npm to pnpm #2817
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| /node_modules | ||
| /.pnpm-store/ | ||
| /public/hot | ||
| /public/storage | ||
| /storage/*.key | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,8 +31,8 @@ if unzip -q -d "$temporaryDirectory" "$downloadFileName"; then | |
| echo "Entering directory $folderName failed" | ||
| exit 2 | ||
| fi | ||
| npm install | ||
| npm run build | ||
| pnpm install | ||
| pnpm run build | ||
|
Comment on lines
+34
to
+35
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: fd "Dockerfile" docker/ --exec cat -n {}Repository: THM-Health/PILOS Length of output: 4584 🏁 Script executed: cat -n docker/app/playback-player/build.shRepository: THM-Health/PILOS Length of output: 1565 🏁 Script executed: cat -n docker/app/pilos-cliRepository: THM-Health/PILOS Length of output: 2504 🌐 Web query:
💡 Result:
Because it does not ship a Consider respecting the bbb-playback project's npm-based dependency management. The external bbb-playback project is configured for npm (ships 🤖 Prompt for AI Agents |
||
|
|
||
| # clear old public folder | ||
| echo "Clearing old player..." | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -60,14 +60,10 @@ function display_help { | |||||||||||||||||
| echo " ${GREEN}sail node ...${NC} Run a Node command" | ||||||||||||||||||
| echo " ${GREEN}sail node --version${NC}" | ||||||||||||||||||
| echo | ||||||||||||||||||
| echo "${YELLOW}NPM Commands:${NC}" | ||||||||||||||||||
| echo " ${GREEN}sail npm ...${NC} Run a npm command" | ||||||||||||||||||
| echo " ${GREEN}sail npx${NC} Run a npx command" | ||||||||||||||||||
| echo " ${GREEN}sail npm run prod${NC}" | ||||||||||||||||||
| echo | ||||||||||||||||||
| echo "${YELLOW}Yarn Commands:${NC}" | ||||||||||||||||||
| echo " ${GREEN}sail yarn ...${NC} Run a Yarn command" | ||||||||||||||||||
| echo " ${GREEN}sail yarn run prod${NC}" | ||||||||||||||||||
| echo "${YELLOW}PNPM Commands:${NC}" | ||||||||||||||||||
| echo " ${GREEN}sail pnpm ...${NC} Run a pnpm command" | ||||||||||||||||||
| echo " ${GREEN}sail pnpx${NC} Run a pnpx command" | ||||||||||||||||||
| echo " ${GREEN}sail pnpm run prod${NC}" | ||||||||||||||||||
|
Comment on lines
+63
to
+66
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Line 65 documents Either add a Option A: Add a pnpx handler (mirrors the npx block)+# Proxy PNPX commands to the "pnpx" binary on the application container...
+elif [ "$1" == "pnpx" ]; then
+ shift 1
+
+ if [ "$EXEC" == "yes" ]; then
+ ARGS+=(exec -u "$APP_USER")
+ [ ! -t 0 ] && ARGS+=(-T)
+ ARGS+=("$APP_SERVICE" pnpx)
+ else
+ sail_is_not_running
+ fi
+
# Proxy NPX commands to the "npx" binary on the application container...
elif [ "$1" == "npx" ]; thenOption B: Update help text to reflect existing handlers echo "${YELLOW}PNPM Commands:${NC}"
echo " ${GREEN}sail pnpm ...${NC} Run a pnpm command"
- echo " ${GREEN}sail pnpx${NC} Run a pnpx command"
+ echo " ${GREEN}sail npx${NC} Run a npx command"
echo " ${GREEN}sail pnpm run prod${NC}"📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||
| echo | ||||||||||||||||||
| echo "${YELLOW}Database Commands:${NC}" | ||||||||||||||||||
| echo " ${GREEN}sail mariadb${NC} Start a MySQL CLI session within the 'db' container" | ||||||||||||||||||
|
|
@@ -339,14 +335,14 @@ elif [ "$1" == "node" ]; then | |||||||||||||||||
| sail_is_not_running | ||||||||||||||||||
| fi | ||||||||||||||||||
|
|
||||||||||||||||||
| # Proxy NPM commands to the "npm" binary on the application container... | ||||||||||||||||||
| elif [ "$1" == "npm" ]; then | ||||||||||||||||||
| # Proxy PNPM commands to the "pnpm" binary on the application container... | ||||||||||||||||||
| elif [ "$1" == "pnpm" ]; then | ||||||||||||||||||
| shift 1 | ||||||||||||||||||
|
|
||||||||||||||||||
| if [ "$EXEC" == "yes" ]; then | ||||||||||||||||||
| ARGS+=(exec -u "$APP_USER") | ||||||||||||||||||
| [ ! -t 0 ] && ARGS+=(-T) | ||||||||||||||||||
| ARGS+=("$APP_SERVICE" npm) | ||||||||||||||||||
| ARGS+=("$APP_SERVICE" pnpm) | ||||||||||||||||||
| else | ||||||||||||||||||
| sail_is_not_running | ||||||||||||||||||
| fi | ||||||||||||||||||
|
|
@@ -363,18 +359,6 @@ elif [ "$1" == "npx" ]; then | |||||||||||||||||
| sail_is_not_running | ||||||||||||||||||
| fi | ||||||||||||||||||
|
|
||||||||||||||||||
| # Proxy Yarn commands to the "yarn" binary on the application container... | ||||||||||||||||||
| elif [ "$1" == "yarn" ]; then | ||||||||||||||||||
| shift 1 | ||||||||||||||||||
|
|
||||||||||||||||||
| if [ "$EXEC" == "yes" ]; then | ||||||||||||||||||
| ARGS+=(exec -u "$APP_USER") | ||||||||||||||||||
| [ ! -t 0 ] && ARGS+=(-T) | ||||||||||||||||||
| ARGS+=("$APP_SERVICE" yarn) | ||||||||||||||||||
| else | ||||||||||||||||||
| sail_is_not_running | ||||||||||||||||||
| fi | ||||||||||||||||||
|
|
||||||||||||||||||
| # Initiate a MySQL CLI terminal session within the "db" container... | ||||||||||||||||||
| elif [ "$1" == "mariadb" ]; then | ||||||||||||||||||
| shift 1 | ||||||||||||||||||
|
|
||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
GitHub Dependabot pnpm support package ecosystem💡 Result:
Dependabot treats pnpm as part of the
npmpackage ecosystem. So in.github/dependabot.ymlyou should use:Dependabot will detect pnpm usage from files like
pnpm-lock.yaml(and workspace setup) while still using thenpmecosystem key. pnpm support: version updates work for pnpm v7–v10, while security updates are supported for pnpm v7–v8 only. [1][2]Also, Dependabot added GA support for
pnpmworkspace catalogs (monorepo catalogs inpnpm-workspace.yaml) on February 4, 2025. [3]Sources: [1] [2] [3]
Change
package-ecosystemback to"npm"—pnpmis not a supported ecosystem value in Dependabot. Instead, use"npm"and Dependabot will automatically detect pnpm frompnpm-lock.yaml. Note: pnpm version updates are supported for v7–v10, while security updates are supported for v7–v8 only.🤖 Prompt for AI Agents