[TASK] Make the plugin a `CType` by linxpinx · Pull Request #1811 · TYPO3BestPractices/tea

linxpinx · 2025-09-25T14:39:53Z

Resources/Private/Language/de.locallang_db.xlf

oliverklee · 2025-09-25T15:37:31Z

Resources/Private/Language/de.locallang_db.xlf

+			</trans-unit>
+			<trans-unit id="plugin.tea_index.title">
+				<source>Tea Index</source>
+				<target>Tea Index</target>


English: Tea list
German: Teeliste

oliverklee · 2025-09-25T15:37:59Z

Resources/Private/Language/de.locallang.xlf

 				<target>Tee-Einzelansicht</target>
 			</trans-unit>
-			<trans-unit id="plugin.tea_frontend_editor" approved="yes">
+			<trans-unit id="plugin.tea_front_end_editor" approved="yes">


Why this change?

I mean that the label was missing before, but now it seems to be there. I'll change it.

oliverklee · 2025-09-25T15:38:23Z

Configuration/TSconfig/Page/ContentElementWizard.tsconfig

@@ -0,0 +1,16 @@
+mod.wizards.newContentElement.wizardItems.ext-tea {


Let's move adding the wizard to a separate, later PR.

ok i`ll create a task for that. #1830

oliverklee · 2025-09-25T15:39:22Z

Classes/Upgrades/ListTypeToCTypeUpdate.php

+use TYPO3\CMS\Install\Attribute\UpgradeWizard;
+
+#[UpgradeWizard('teaListTypeToCTypeUpdate')]
+final class ListTypeToCTypeUpdate extends AbstractListTypeToCTypeUpdate


This upgrade wizard needs functional tests.

Also, we need tests for the copied base class. (When we copy code, it becomes our responsibility, and it then falls under the same code quality standards as the rest of our code.)

@oliverklee I added some functional tests for the Upgrade Wizard.
As for the copied base class: I don't want to put so much work into a class that I only need for one version. Is there a solution that would suit both you and me? Otherwise, I suggest opening a separate PR for this issue.

oliverklee · 2025-09-25T15:40:16Z

Build/phpstan/phpstan.neon

      message: 'Use PSR-7 API instead'
+
+  excludePaths:
+    # We need this Class only for V12. So we exclude it here


No, we should allow PHPStan to scan it. It should be possible to run the upgrade wizard in V13 as well.

@oliverklee in V13 this Class is in cms-install. So we don't need the Class from Lina. For that reason I decided to exclude it from PHPStan.

Please don't exclude the upgrade wizard from PHPStan. Otherwise, if it is not scanned, we cannot see any warnings in the class.

Build/composer-unused/composer-unused.php

oliverklee · 2025-10-23T16:09:28Z

Build/phpstan/phpstan.neon

      message: 'Use PSR-7 API instead'
+
+  excludePaths:
+    # We need this Class only for V12. So we exclude it here


Please don't exclude the upgrade wizard from PHPStan. Otherwise, if it is not scanned, we cannot see any warnings in the class.

oliverklee · 2025-10-23T16:11:16Z

Classes/Upgrades/ListTypeToCTypeUpdate.php

+use TYPO3\CMS\Install\Attribute\UpgradeWizard;
+
+#[UpgradeWizard('teaListTypeToCTypeUpdate')]
+final class ListTypeToCTypeUpdate extends AbstractListTypeToCTypeUpdate


Also, we need tests for the copied base class. (When we copy code, it becomes our responsibility, and it then falls under the same code quality standards as the rest of our code.)

Resources/Private/Language/de.locallang_db.xlf

Resources/Private/Language/locallang_db.xlf

Related: #1811

Fixes #1332

Related: #1811

coveralls · 2025-12-04T09:37:54Z

Pull Request Test Coverage Report for Build 21594813326

Details

10 of 172 (5.81%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-57.2%) to 42.756%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
Classes/Upgrades/AbstractListTypeToCTypeUpdate.php	0	162	0.0%

Totals
Change from base Build 21594446602:	-57.2%
Covered Lines:	121
Relevant Lines:	283

💛 - Coveralls

Related: #1811

oliverklee · 2026-02-02T14:32:26Z

@Starkmann Could you please rebase this branch? This hopefully also should get rid of the "merge main into this branch" commit.

Related: #1811

Starkmann · 2026-02-02T15:03:27Z

AbstractListTypeToCTypeUpdate is tested in ListTypeToCTypeUpdateTest

Starkmann · 2026-02-02T15:04:05Z

@Starkmann Could you please rebase this branch? This hopefully also should get rid of the "merge main into this branch" commit.

I get really strange conflicts when rebasing.

Related: #1811

oliverklee · 2026-02-02T16:51:01Z

Marking as draft so we know this PR isn't intended to be merged.

linxpinx added the task label Sep 25, 2025

linxpinx mentioned this pull request Sep 25, 2025

1332 make plugin a ctype #1767

Closed

oliverklee requested changes Sep 25, 2025

View reviewed changes

oliverklee requested changes Oct 23, 2025

View reviewed changes

linxpinx force-pushed the task/1332-make-plugin-ctype branch from 23af684 to 14eba5a Compare October 31, 2025 19:10

oliverklee added this to the 4.0.0: Breaking changes milestone Nov 30, 2025

oliverklee added this to Best Practices Remote Day Nov 30, 2025

oliverklee moved this to In Progress in Best Practices Remote Day Nov 30, 2025

oliverklee assigned Starkmann Dec 1, 2025

Starkmann added a commit that referenced this pull request Dec 3, 2025

[TASK] increase test coverage and also test user rights migration

a5d21e9

Related: #1811

oliverklee changed the title ~~[TASK] Make plugin CType~~ [TASK] Make the plugin a CType Dec 4, 2025

linxpinx and others added 2 commits December 4, 2025 10:35

[TASK] Make the plugin a CType

6f96424

Fixes #1332

[TASK] increase test coverage and also test user rights migration

4b130dc

Related: #1811

oliverklee force-pushed the task/1332-make-plugin-ctype branch from a5d21e9 to 4b130dc Compare December 4, 2025 09:35

Starkmann added a commit that referenced this pull request Feb 2, 2026

[TASK] ignore SC2046 and SC2128

9d03f07

Related: #1811

Starkmann added 2 commits February 2, 2026 15:19

Merge branch 'main' into task/1332-make-plugin-ctype

e302620

[BUGFIX] apply cs fixer

57db098

Related: #1811

Starkmann added 2 commits February 2, 2026 15:50

[TASK] don't exclude AbstractListTypeToCTypeUpdate

8d249da

Related: #1811

Merge branch 'main' into task/1332-make-plugin-ctype

3a2cabc

Starkmann added a commit that referenced this pull request Feb 2, 2026

[TASK] increase test coverage and also test user rights migration

ce01511

Related: #1811

Starkmann added a commit that referenced this pull request Feb 2, 2026

[BUGFIX] apply cs fixer

c8f9caa

Related: #1811

Starkmann added a commit that referenced this pull request Feb 2, 2026

[TASK] don't exclude AbstractListTypeToCTypeUpdate

0f6108c

Related: #1811

oliverklee marked this pull request as draft February 2, 2026 16:51

		@@ -0,0 +1,16 @@
		mod.wizards.newContentElement.wizardItems.ext-tea {

Conversation

linxpinx commented Sep 25, 2025 • edited by oliverklee Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

oliverklee Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

linxpinx Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coveralls commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 21594813326

Details

💛 - Coveralls

Uh oh!

oliverklee commented Feb 2, 2026

Uh oh!

Starkmann commented Feb 2, 2026

Uh oh!

Starkmann commented Feb 2, 2026

Uh oh!

oliverklee commented Feb 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

linxpinx commented Sep 25, 2025 •

edited by oliverklee

Loading

oliverklee Sep 25, 2025 •

edited

Loading

linxpinx Oct 20, 2025 •

edited

Loading

coveralls commented Dec 4, 2025 •

edited

Loading