[BUGFIX] Fix SQLite functional tests with Docker on WSL2#1932
Draft
oliverklee wants to merge 1 commit intomainfrom
Draft
[BUGFIX] Fix SQLite functional tests with Docker on WSL2#1932oliverklee wants to merge 1 commit intomainfrom
oliverklee wants to merge 1 commit intomainfrom
Conversation
Pull Request Test Coverage Report for Build 21289227642Details
💛 - Coveralls |
SQLite functional tests failed with "unable to open database file" because the container user had no permission to write to the tmpfs mount directory. Adding uid/gid options to the tmpfs mount fixes this. This is a copy of the corresponding change from the TYPO3 Core `runTests.sh`: https://review.typo3.org/c/Packages/TYPO3.CMS/+/92388 Fixes #1925
d42173a to
a67ee29
Compare
Contributor
|
@oliverklee This does not make sense. The core change was related to have that for the functional sqlite test and the "tmpfs" mount (ramdisk). This does not exists for this extension anymore. It has been removed with #1394 to solve #1222. My (unpopular) opinion on that:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLite functional tests failed with "unable to open database file" because the container user had no permission to write to the tmpfs mount directory. Adding uid/gid options to the tmpfs mount fixes this.
This is a copy of the corresponding change from the TYPO3 Core
runTests.sh:https://review.typo3.org/c/Packages/TYPO3.CMS/+/92388
Fixes #1925