[BUGFIX] Return exitcode != 0 when runTests.sh -s composerUpdate(Min|Max) fails#1936
Draft
sbuerk wants to merge 1 commit intoTYPO3BestPractices:mainfrom
Draft
Conversation
Pull Request Test Coverage Report for Build 21316108713Details
💛 - Coveralls |
…|Max)` fails The two `Build/Scripts/runTests.sh -s composerUpdateMin` and `Build/Scripts/runTests.sh -s composerUpdateMax` uses multiple commands passed to a single php container as chained command concatenated using `;` executing all commands, not stopping if one failes only returning the exit code of the last command `composer show`, which is mostly `0` and communication success. This change reworks the command building using `&&` to chain the commands and abort in case one fails and using exitcode of the failed command. Resolves: TYPO3BestPractices#1882
sbuerk
force-pushed
the
bugfix/runtests-composerupdate-exitcode-handling
branch
from
f2f4b41 to
fc844c4
Compare
oliverklee
added this to the
4.0.0: Drop support for TYPO3 11LTS and PHP 7.4/8.0, add support for 13LTS milestone
Contributor
|
Thanks a lot, @sbuerk! 🙏 Marking as draft so we can resolve the to-dos first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two
Build/Scripts/runTests.sh -s composerUpdateMinandBuild/Scripts/runTests.sh -s composerUpdateMaxuses multiplecommands passed to a single php container as chained command
concatenated using
;executing all commands, not stoppingif one failes only returning the exit code of the last command
composer show, which is mostly0and communication success.This change reworks the command building using
&&to chainthe commands and abort in case one fails and using exitcode
of the failed command.
Resolves: #1882