-
-
Notifications
You must be signed in to change notification settings - Fork 3
Add Nix flake and Home Manager module #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @Bircoder432, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces Nix flake and Home Manager module support for rustormy, which is a great addition for Nix users. The changes include modifying .gitignore to allow Cargo.lock for deterministic builds with Naersk, and adding flake.nix, flake.lock, and home-manager/home.nix files. The flake.nix provides a basic flake for building the Rust package, and the Home Manager module allows easy installation and configuration. Overall, the implementation is well-structured, but there are a few areas for improvement regarding hardcoded values, consistency in configuration keys, and example syntax.
Hello!
I thought packaging
rustormyfor Nix would be useful. This PR adds:x86_64-linuxtarget using Naersk to build the Rust package.rustormyand configuring it via~/.config/rustormy/config.toml. Default settings are applied automatically but can be overridden by the user.Cargo.lock:
Cargo.lockwas removed from.gitignorebecause Naersk requires aCargo.lockfor deterministic builds. Without it, builds could vary depending on the latest versions of dependencies. IncludingCargo.lockensures reproducible packaging for Nix.Example usage with NixOS + Home Manager: