You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Wanted to try out your awesome plugin, but it breaks builds for people who do not use default (f.e. using bevy_seedling instead of bevy_audio)
This narrows features so that it is usable for someone who does not rely on default features, tested a few examples, it worked I guess, however day shader was a bit crazy bright :D
Nice catch.
I see you swapped out bevy version from "0.17" to "0.17.3".
I'm unsure what the best practice is for libraries when it comes to version selection.
I set it to "0.17" so we can support all minor bevy versions. (I don't know why someone would use lower versions... but maybe it's a good idea to support that..?).
Can someone give some insight as to the best practice when it comes to versioning.
Hmm, I also use 0.17 in my binary project, my logic was that for libraries it's generally better to be as specific as possible, I guess I can change it back to 0.17 if you'd want to just offload it to the user
That is the same. If you meant =0.17 or 0.17, the latter is the better choice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wanted to try out your awesome plugin, but it breaks builds for people who do not use default (f.e. using bevy_seedling instead of bevy_audio)
This narrows features so that it is usable for someone who does not rely on default features, tested a few examples, it worked I guess, however day shader was a bit crazy bright :D