NPE-582: Add support for Ruby 4 #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the resolv-replace patch, which it's believed we no longer need on newer versions of Ruby
obrie
force-pushed
the
feature/npe-582-ruby4
branch
from
9512188 to
6e05efb
Compare
captainkevron
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.unity3d.com/browse/NPE-582
The
resolve-replacegem is not compatible with Ruby 4: ruby/resolv-replace#3This patch was originally introduced to address deadlocks resulting from forking while a mutex lock was held by another Thread. This should no longer be a problem in newer versions of Ruby, so I'm just removing it.