sock_addr_validate: remove redundant expression#418
Conversation
|
Whoops, this slipped through the cracks. I normally run Then when I was importing this change to |
|
The original code was redundant but was easier to understand -- "check for a missing hostname" doesn't make sense by itself since local socket paths don't have hostnames. We can change the code if you want to keep clang-tidy happy but the comment should explain that local socket paths will pass the test since they start with |
If we start with ':', then that character can't be '/'!
This should have been part of:
2025-01-12 sock_util: add sock_addr_validate()
856d33c
Reported by: clang-tidy-19 misc-redundant-expression
9ccf3bd to
539daf2
Compare
|
Ok, revised comment. It feels a bit wordy, but I couldn't think of a shorter way without ambiguity. In case you were wondering: I disable approximately 70 clang-tidy checks; the remainder are ones which I think could give useful warnings in some cases. |
No description provided.